From: Oleg Nesterov <oleg@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Alexander van Heukelum <heukelum@fastmail.fm>,
Andi Kleen <ak@linux.intel.com>,
Clark Williams <williams@redhat.com>,
Luis Goncalves <lgoncalv@redhat.com>,
stable-rt@vger.kernel.org
Subject: Re: [PATCH RT 2/2 v4] preempt-rt/x86: Delay calling signals in int3
Date: Fri, 3 Feb 2012 19:40:16 +0100 [thread overview]
Message-ID: <20120203184016.GA10413@redhat.com> (raw)
In-Reply-To: <20120203183041.427463295@goodmis.org>
Steven, I guess I need to actually read the patch before asking the
questions... I'll try later, but
On 02/03, Steven Rostedt wrote:
>
> --- linux-rt.git.orig/arch/x86/kernel/entry_64.S
> +++ linux-rt.git/arch/x86/kernel/entry_64.S
> @@ -1391,6 +1391,14 @@ paranoid_userspace:
> paranoid_schedule:
> TRACE_IRQS_ON
> ENABLE_INTERRUPTS(CLBR_ANY)
> +#ifdef CONFIG_PREEMPT_RT_FULL
> + GET_THREAD_INFO(%rcx)
> + movl TI_flags(%rcx),%ebx
> + testl $_TIF_FORCE_SIG_TRAP,%ebx
> + jz paranoid_do_schedule
> + call do_force_sig_trap
> +paranoid_do_schedule:
> +#endif
Stupid question. Do we really need to send the signal from here?
Why force_sig(rt => T) can't set TIF_NOTIFY_RESUME instead? Then
we can change do_notify_resume() to check TIF_FORCE_SIG_TRAP. And
perhaps we can even avoid the new TIF_FORCE_SIG_TRAP, we could
check task->stored_info_set.
In fact I feel this can be simplified even more, but I am not sure.
Oleg.
next prev parent reply other threads:[~2012-02-03 18:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 18:28 [PATCH RT 0/2 v4] preempt-rt/x86: Handle sending signals from do_trap() by gdb Steven Rostedt
2012-02-03 18:28 ` [PATCH RT 1/2 v4] x86: Do not disable preemption in int3 on 32bit Steven Rostedt
2012-02-03 18:28 ` [PATCH RT 2/2 v4] preempt-rt/x86: Delay calling signals in int3 Steven Rostedt
2012-02-03 18:40 ` Oleg Nesterov [this message]
2012-02-03 20:10 ` Steven Rostedt
2012-02-05 19:23 ` Oleg Nesterov
2012-02-05 19:31 ` Oleg Nesterov
2012-02-06 16:12 ` Steven Rostedt
2012-02-06 16:25 ` Oleg Nesterov
2012-02-06 16:38 ` Steven Rostedt
2012-02-07 14:17 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120203184016.GA10413@redhat.com \
--to=oleg@redhat.com \
--cc=C.Emde@osadl.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=heukelum@fastmail.fm \
--cc=hpa@zytor.com \
--cc=jkacur@redhat.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=stable-rt@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).