From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757932Ab2BCVK7 (ORCPT ); Fri, 3 Feb 2012 16:10:59 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:51212 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757919Ab2BCVK6 (ORCPT ); Fri, 3 Feb 2012 16:10:58 -0500 Date: Fri, 3 Feb 2012 13:10:54 -0800 From: Tejun Heo To: Vivek Goyal Cc: axboe@kernel.dk, ctalbott@google.com, rni@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH UPDATED 11/11] blkcg: unify blkg's for blkcg policies Message-ID: <20120203211054.GD14209@google.com> References: <1328131156-13290-1-git-send-email-tj@kernel.org> <1328131156-13290-12-git-send-email-tj@kernel.org> <20120202003730.GC19837@google.com> <20120203210656.GB12616@redhat.com> <20120203210922.GC14209@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120203210922.GC14209@google.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 03, 2012 at 01:09:22PM -0800, Tejun Heo wrote: > Hello, > > On Fri, Feb 03, 2012 at 04:06:56PM -0500, Vivek Goyal wrote: > > Shouldn't we shoot down root group policy data upon elevator switch? > > Otherwise once the elevator comes back, it will continue to use old > > policy data (old stats, overwrite old weigts etc.). > > It's racy and hacky but we do shoot down policy specific data and > reinit them. The behavior should be fine although implementation is > seriously ugly for now. Oops, sorry, got confused again about elvswitch and pol registration. Hmmm... yeah, we should probably be doing about the same thing on elvswitch. I'll look into it. Thanks. -- tejun