From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754161Ab2BDSDS (ORCPT ); Sat, 4 Feb 2012 13:03:18 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:43626 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753559Ab2BDSDR (ORCPT ); Sat, 4 Feb 2012 13:03:17 -0500 Date: Sat, 4 Feb 2012 19:02:37 +0100 From: Ingo Molnar To: Joe Perches Cc: Linus Torvalds , Andy Whitcroft , Andrew Morton , Cyrill Gorcunov , linux-kernel@vger.kernel.org, Pavel Emelyanov , Serge Hallyn , KAMEZAWA Hiroyuki , Kees Cook , Tejun Heo , Andrew Vagin , "Eric W. Biederman" , Alexey Dobriyan , Andi Kleen , KOSAKI Motohiro , "H. Peter Anvin" , Thomas Gleixner , Glauber Costa , Matt Helsley , Pekka Enberg , Eric Dumazet , Vasiliy Kulikov , Valdis.Kletnieks@vt.edu Subject: Re: [PATCH, v2] checkpatch: Warn on code with 6+ tab indentation, remove 80col warning Message-ID: <20120204180237.GA7682@elte.hu> References: <20120203074656.GC30543@elte.hu> <20120203083530.GD1968@moon> <20120203090929.GA23996@elte.hu> <20120203012241.bcd3d0c8.akpm@linux-foundation.org> <20120203095227.GA13162@elte.hu> <20120203100743.GA3334@elte.hu> <1328311239.21255.24.camel@joe2Laptop> <20120204130330.GA30198@elte.hu> <1328372536.5766.3.camel@joe2Laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1328372536.5766.3.camel@joe2Laptop> User-Agent: Mutt/1.5.21 (2010-09-15) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=AWL,BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 AWL AWL: From: address is in the auto white-list Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Joe Perches wrote: > On Sat, 2012-02-04 at 14:03 +0100, Ingo Molnar wrote: > > * Joe Perches wrote: > > > Overly indented code should be refactored. > > _AND_ the 80 cols warning should be removed. The overwhelming > > majority of developers either ignore the 80 cols warning or make > > the code worse as a result of the warning. > > Perhaps, but it should be a separate patch > and you'd still need to update CodingStyle. Why would I have to update CodingStyle? The 80col limit remains, it's just removed from *checkpatch*. Thanks, Ingo