From: Daniel Vetter <daniel@ffwll.ch>
To: Dave Airlie <airlied@gmail.com>
Cc: Keith Packard <keithp@keithp.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Lubos Kolouch <lubos.kolouch@gmail.com>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Force explicit bpp selection for intel_dp_link_required
Date: Mon, 6 Feb 2012 17:03:37 +0100 [thread overview]
Message-ID: <20120206160337.GB4066@phenom.ffwll.local> (raw)
In-Reply-To: <CAPM=9tyg6Ju8qi+Qy0XP-23wApGA3+12jDfd7KQRoZ_bqSH=4g@mail.gmail.com>
On Mon, Feb 06, 2012 at 12:12:16PM +0000, Dave Airlie wrote:
> On Fri, Jan 27, 2012 at 10:30 AM, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Wed, Jan 25, 2012 at 08:16:25AM -0800, Keith Packard wrote:
> >> It is never correct to use intel_crtc->bpp in intel_dp_link_required,
> >> so instead pass an explicit bpp in to this function. This patch
> >> only supports 18bpp and 24bpp modes, which means that 10bpc modes will
> >> be computed incorrectly. Fixing that will require more extensive
> >> changes, and so must be addressed separately from this bugfix.
> >>
> >> intel_dp_link_required is called from intel_dp_mode_valid and
> >> intel_dp_mode_fixup.
> >>
> >> * intel_dp_mode_valid is called to list supported modes; in this case,
> >> the current crtc values cannot be relevant as the modes in question
> >> may never be selected. Thus, using intel_crtc->bpp is never right.
> >>
> >> * intel_dp_mode_fixup is called during mode setting, but it is run
> >> well before ironlake_crtc_mode_set is called to set intel_crtc->bpp,
> >> so using intel_crtc-bpp in this path can only ever get a stale
> >> value.
> >>
> >> Cc: Lubos Kolouch <lubos.kolouch@gmail.com>
> >> Cc: Adam Jackson <ajax@redhat.com>
> >> Signed-off-by: Keith Packard <keithp@keithp.com>
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42263
> > Tested-by: camalot@picnicpark.org (Dell Latitude 6510)
> >
> > Not the original reporter and might not exactly be this bug, but likely.
> > -Daniel
>
> Tested-by: Dave Airlie <airlied@redhat.com>
Another bugzilla for this patch:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44881
Tested-by: Roland Dreier <roland@digitalvampire.org>
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-02-06 16:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 16:16 [PATCH 0/2] drm/i915: Use correct bpc computations for DisplayPort Keith Packard
2012-01-25 16:16 ` [PATCH 1/2] drm/i915: Force explicit bpp selection for intel_dp_link_required Keith Packard
2012-01-25 20:51 ` [Intel-gfx] " Jesse Barnes
2012-01-25 21:17 ` Keith Packard
2012-01-25 21:50 ` Daniel Vetter
2012-01-25 22:45 ` Keith Packard
2012-01-25 21:52 ` Daniel Vetter
2012-01-27 10:30 ` Daniel Vetter
2012-02-06 12:12 ` Dave Airlie
2012-02-06 16:03 ` Daniel Vetter [this message]
2012-02-06 22:10 ` Keith Packard
2012-01-25 16:16 ` [PATCH 2/2] drm/i915: Select DP BPC at mode set, rather than mode validate Keith Packard
2012-01-25 22:11 ` [Intel-gfx] " Daniel Vetter
2012-01-25 22:56 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206160337.GB4066@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lubos.kolouch@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).