linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: rtc-linux@googlegroups.com
Cc: Yauhen Kharuzhy <yauhen.kharuzhy@promwad.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	linux-kernel@vger.kernel.org, Ivan Kuten <ivan.kuten@promwad.com>
Subject: Re: [rtc-linux] [PATCH] RTC: Add driver for NXP PCF8523 RTC chip
Date: Tue, 7 Feb 2012 15:28:15 -0800	[thread overview]
Message-ID: <20120207152815.6311c59a.akpm@linux-foundation.org> (raw)
In-Reply-To: <1317815823-27297-1-git-send-email-yauhen.kharuzhy@promwad.com>

On Wed,  5 Oct 2011 14:57:03 +0300
Yauhen Kharuzhy <yauhen.kharuzhy@promwad.com> wrote:

> This driver is based on PCF8563 driver and supports only base functions
> now: read/write date & time.

This patch breaks my x86_64 allmodconfig build.

drivers/rtc/rtc-pcf8523.c: In function 'pcf8523_get_datetime':
drivers/rtc/rtc-pcf8523.c:55: warning: unused variable 'pcf8523'
drivers/rtc/rtc-pcf8523.c: In function 'pcf8523_set_datetime':
drivers/rtc/rtc-pcf8523.c:110: warning: unused variable 'pcf8523'
drivers/rtc/rtc-pcf8523.c: In function 'pcf8523_probe':
drivers/rtc/rtc-pcf8523.c:179: error: invalid application of 'sizeof' to incomplete type 'struct pcf8523' 
drivers/rtc/rtc-pcf8523.c:187: error: dereferencing pointer to incomplete type
drivers/rtc/rtc-pcf8523.c:188: error: 'THIS_MODULE' undeclared (first use in this function)
drivers/rtc/rtc-pcf8523.c:188: error: (Each undeclared identifier is reported only once
drivers/rtc/rtc-pcf8523.c:188: error: for each function it appears in.)
drivers/rtc/rtc-pcf8523.c:190: error: dereferencing pointer to incomplete type
drivers/rtc/rtc-pcf8523.c:191: error: dereferencing pointer to incomplete type
drivers/rtc/rtc-pcf8523.c: In function 'pcf8523_remove':
drivers/rtc/rtc-pcf8523.c:207: error: dereferencing pointer to incomplete type
drivers/rtc/rtc-pcf8523.c:208: error: dereferencing pointer to incomplete type
drivers/rtc/rtc-pcf8523.c: At top level:
drivers/rtc/rtc-pcf8523.c:219: warning: data definition has no type or storage class
drivers/rtc/rtc-pcf8523.c:219: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
drivers/rtc/rtc-pcf8523.c:219: warning: parameter names (without types) in function declaration
drivers/rtc/rtc-pcf8523.c: In function 'pcf8523_init':
drivers/rtc/rtc-pcf8523.c:232: error: 'THIS_MODULE' undeclared (first use in this function)
drivers/rtc/rtc-pcf8523.c: At top level:
drivers/rtc/rtc-pcf8523.c:240: error: expected declaration specifiers or '...' before string constant
drivers/rtc/rtc-pcf8523.c:240: warning: data definition has no type or storage class
drivers/rtc/rtc-pcf8523.c:240: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
drivers/rtc/rtc-pcf8523.c:240: warning: function declaration isn't a prototype
drivers/rtc/rtc-pcf8523.c:241: error: expected declaration specifiers or '...' before string constant
drivers/rtc/rtc-pcf8523.c:241: warning: data definition has no type or storage class
drivers/rtc/rtc-pcf8523.c:241: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
drivers/rtc/rtc-pcf8523.c:241: warning: function declaration isn't a prototype
drivers/rtc/rtc-pcf8523.c:242: error: expected declaration specifiers or '...' before string constant
drivers/rtc/rtc-pcf8523.c:242: warning: data definition has no type or storage class
drivers/rtc/rtc-pcf8523.c:242: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
drivers/rtc/rtc-pcf8523.c:242: warning: function declaration isn't a prototype
drivers/rtc/rtc-pcf8523.c:243: error: expected declaration specifiers or '...' before string constant
drivers/rtc/rtc-pcf8523.c:243: warning: data definition has no type or storage class
drivers/rtc/rtc-pcf8523.c:243: warning: type defaults to 'int' in declaration of 'MODULE_VERSION'
drivers/rtc/rtc-pcf8523.c:243: warning: function declaration isn't a prototype


      parent reply	other threads:[~2012-02-07 23:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-05 11:57 [PATCH] RTC: Add driver for NXP PCF8523 RTC chip Yauhen Kharuzhy
2012-02-01 23:52 ` [rtc-linux] " Andrew Morton
2012-02-02  3:23   ` Venu Byravarasu
2012-02-07 23:28 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120207152815.6311c59a.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=a.zummo@towertech.it \
    --cc=ivan.kuten@promwad.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    --cc=yauhen.kharuzhy@promwad.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).