From: Ben Hutchings <ben@decadent.org.uk>
To: Michal Marek <mmarek@suse.cz>,
Joerg Roedel <joerg.roedel@amd.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
debian-kernel@lists.debian.org
Subject: Re: [PATCH] kbuild: Fix link to headers in 'make deb-pkg'
Date: Tue, 7 Feb 2012 16:37:16 +0000 [thread overview]
Message-ID: <20120207163716.GA12704@decadent.org.uk> (raw)
In-Reply-To: <20120204143449.GA28068@stro.at>
On Sat, Feb 04, 2012 at 03:34:49PM +0100, maximilian attems wrote:
> adding bwh + debian-kernel
>
> On Mon, 23 Jan 2012, Michal Marek wrote:
>
> > (adding max to CC)
> >
> > On 23.1.2012 12:40, Joerg Roedel wrote:
> > > The Link to the kernel header files in the debian packages
> > > point to the original build directory. This is a bad choice
> > > if the packages were installed on a different machine. Fix
> > > this in by manually re-creating the link in the builddeb
> > > script.
Right, but:
[...]
> > > @@ -121,10 +122,14 @@ fi
> > >
> > > if grep -q '^CONFIG_MODULES=y' .config ; then
> > > INSTALL_MOD_PATH="$tmpdir" make KBUILD_SRC= modules_install
> > > - if [ "$ARCH" = "um" ] ; then
> > > - mv "$tmpdir/lib/modules/$version"/* "$tmpdir/usr/lib/uml/modules/$version/"
> > > - rmdir "$tmpdir/lib/modules/$version"
> > > - fi
> > > +fi
> > > +
> > > +# Make sure link to the headers is correct
> > > +ln -snf "/usr/src/$kernel_headers_packagename" "$tmpdir/lib/modules/$version/build"
[...]
This should be removed from the kernel image package and created
in the kernel headers package instead, otherwise it's potentially a
broken link.
Ben.
--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus
prev parent reply other threads:[~2012-02-07 16:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 11:40 [PATCH] kbuild: Fix link to headers in 'make deb-pkg' Joerg Roedel
2012-01-23 16:17 ` Michal Marek
2012-01-31 11:05 ` Joerg Roedel
2012-01-31 11:10 ` Michal Marek
2012-01-31 11:27 ` Joerg Roedel
2012-02-04 14:34 ` maximilian attems
2012-02-07 16:37 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120207163716.GA12704@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=debian-kernel@lists.debian.org \
--cc=joerg.roedel@amd.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).