linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
To: Alex Shi <alex.shi@intel.com>, stern@rowland.harvard.edu
Cc: Greg KH <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, andiry.xu@amd.com,
	linux-kernel@vger.kernel.org, Oliver Neukum <oneukum@suse.de>,
	Takashi Iwai <tiwai@suse.de>,
	trenn@suse.de, linux-pci@vger.kernel.org,
	Michal Marek <MMarek@suse.com>
Subject: Re: [PATCH] usb: enable pci MSI/MSIX in usb core
Date: Tue, 7 Feb 2012 09:27:43 -0800	[thread overview]
Message-ID: <20120207172743.GA4780@xanatos> (raw)
In-Reply-To: <20120207144204.GA7214@kroah.com>

On Tue, Feb 07, 2012 at 06:42:04AM -0800, Greg KH wrote:
> On Tue, Feb 07, 2012 at 07:59:47PM +0800, Alex Shi wrote:
> > On 02/06/2012 08:29 PM, Alex Shi wrote:
> > 
> > > MSI/MSIX is the favorite interrupt for PCIe device. PCIe usb HCD should
> > > be used more and more in future, but current USB core still just wants
> > > line IRQ, only XHCI usb driver enabled MSI/MSIX.
> > > 
> > > This patch enabled pci MSI/MSIX in usb core for HCD, and removed MSI/MSIX
> > > setup code from XHCI since it becomes redundant now.
> > > There 2 places need prepare to enable MSI/MSIX in usb driver.
> > > 1, set HCD_MSI_FIRST in driver->flags to enable MSI/MSIX.
> > > 2, prepare a get_msix_num() for specific drivers.
> > > XHCI is a good example for this.
> > > 
> > > This patch bases on my "USB-try-MSI-before-legacy-irq-on-pci-xhci-HCD"
> > > patch.
> > 
> > 
> > Gregkh&Alan:
> > 
> > Do you need a full patch that include my recent MSI setup/bug fix
> > patches? or just this one is ok?
> 
> I was thinking that Sarah would forward this on.  We need whatever
> should be applied to the tree, as I do not have any pending patches from
> you in my queue.

I'm trying to track down an oops on my for-usb-linus queue that could
either be related to Alex's original MSI work around patch, or the patch
Oliver posted for working around PCI MMIO not being enabled fast enough.
I don't want to review this MSI improvement patch until I'm sure the
original MSI work around patch is stable.

Alex, please give me time to debug bug fixes for 3.3 before pushing on
features for 3.4.

Sarah Sharp

  reply	other threads:[~2012-02-07 17:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-06 12:29 [PATCH] usb: enable pci MSI/MSIX in usb core Alex Shi
2012-02-07 11:59 ` Alex Shi
2012-02-07 14:42   ` Greg KH
2012-02-07 17:27     ` Sarah Sharp [this message]
2012-02-07 22:13       ` Sarah Sharp
2012-02-08  1:26         ` Alex,Shi
2012-02-08  6:27           ` Alex,Shi
2012-02-08  9:11             ` Alex,Shi
2012-02-14  0:20               ` Sarah Sharp
2012-02-14  0:25                 ` [RFT] USB: Try MSI first before line IRQ for Intel PCIe USB3 HCD Sarah Sharp
2012-02-14  4:43                   ` Alex,Shi
2012-02-16  2:36                 ` [PATCH] usb: enable pci MSI/MSIX in usb core Alex,Shi
2012-02-17  6:44                   ` Alex,Shi
2012-02-17  8:13                     ` Clemens Ladisch
2012-02-17  8:46                       ` Alex,Shi
2012-02-17 10:15                         ` Clemens Ladisch
2012-02-18  6:28                           ` Andiry Xu
2012-02-20  0:57                             ` Alex,Shi
2012-02-20  3:52                     ` Alex,Shi
2012-02-08 15:07         ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120207172743.GA4780@xanatos \
    --to=sarah.a.sharp@linux.intel.com \
    --cc=MMarek@suse.com \
    --cc=alex.shi@intel.com \
    --cc=andiry.xu@amd.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.de \
    --cc=stern@rowland.harvard.edu \
    --cc=tiwai@suse.de \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).