From: "John W. Linville" <linville@tuxdriver.com>
To: Joe Perches <joe@perches.com>
Cc: "Devendra.Naga" <devendra.aaru@gmail.com>,
Larry.Finger@lwfinger.net, chaoming_li@realsil.com.cn,
paul.gortmaker@windriver.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi/rtl8192c: in _rtl92c_phy_calculate_bit_shift remove comparing bitmask against 1
Date: Wed, 8 Feb 2012 14:57:44 -0500 [thread overview]
Message-ID: <20120208195744.GD2929@tuxdriver.com> (raw)
In-Reply-To: <1327995440.1804.16.camel@joe2Laptop>
On Mon, Jan 30, 2012 at 11:37:20PM -0800, Joe Perches wrote:
> On Tue, 2012-01-31 at 02:11 -0500, Devendra.Naga wrote:
> > From: "Devendra.Naga" <devendra.aaru@gmail.com>
> []
> > diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
> []
> > @@ -177,7 +177,7 @@ u32 _rtl92c_phy_calculate_bit_shift(u32 bitmask)
> > u32 i;
> >
> > for (i = 0; i <= 31; i++) {
> > - if (((bitmask >> i) & 0x1) == 1)
> > + if ((bitmask >> i) & 0x1)
> > break;
> > }
> > return i;
>
> Perhaps this is simpler and faster:
>
> {
> u32 rtn = (u32)ffs((int)bitmask);
> if (rtn)
> return rtn - 1;
> return 32;
> }
Are you planning to revise your patch based on Joe's suggestion?
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2012-02-08 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 7:11 [PATCH] rtlwifi/rtl8192c: in _rtl92c_phy_calculate_bit_shift remove comparing bitmask against 1 Devendra.Naga
2012-01-31 7:37 ` Joe Perches
2012-02-08 19:57 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120208195744.GD2929@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=devendra.aaru@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).