From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757487Ab2BICbE (ORCPT ); Wed, 8 Feb 2012 21:31:04 -0500 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:38270 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756928Ab2BICbD (ORCPT ); Wed, 8 Feb 2012 21:31:03 -0500 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Thu, 9 Feb 2012 11:29:36 +0900 From: KAMEZAWA Hiroyuki To: Naoya Horiguchi Cc: linux-mm@kvack.org, Andrew Morton , David Rientjes , Andi Kleen , Wu Fengguang , Andrea Arcangeli , KOSAKI Motohiro , linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] pagemap: introduce data structure for pagemap entry Message-Id: <20120209112936.1395fc2c.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <1328716302-16871-7-git-send-email-n-horiguchi@ah.jp.nec.com> References: <1328716302-16871-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1328716302-16871-7-git-send-email-n-horiguchi@ah.jp.nec.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.1.1 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 8 Feb 2012 10:51:42 -0500 Naoya Horiguchi wrote: > Currently a local variable of pagemap entry in pagemap_pte_range() > is named pfn and typed with u64, but it's not correct (pfn should > be unsigned long.) Does this means "the name 'pfn' implies unsigned long, usually. And this usage is confusing." ? > This patch introduces special type for pagemap entry and replace > code with it. > > Signed-off-by: Naoya Horiguchi > Cc: Andrew Morton > Reviewed-by: KAMEZAWA Hiroyuki