From: Greg KH <greg@kroah.com>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Nitin Gupta <ngupta@vflare.org>
Subject: Re: linux-next: build failure after merge of the final tree (staging tree related)
Date: Mon, 13 Feb 2012 07:03:09 -0800 [thread overview]
Message-ID: <20120213150309.GA10009@kroah.com> (raw)
In-Reply-To: <4F3922A5.5030502@linux.vnet.ibm.com>
On Mon, Feb 13, 2012 at 08:48:05AM -0600, Seth Jennings wrote:
> On 02/13/2012 12:45 AM, Greg KH wrote:
> > On Mon, Feb 13, 2012 at 05:19:49PM +1100, Stephen Rothwell wrote:
> >> Hi ,
> >>
> >> After merging the final tree, today's linux-next build (powerpc allyesconfig)
> >> failed like this:
> >>
> >> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_cpu_notifier':
> >> drivers/staging/zsmalloc/zsmalloc-main.c:451:3: error: implicit declaration of function 'alloc_vm_area' [-Werror=implicit-function-declaration]
> >> drivers/staging/zsmalloc/zsmalloc-main.c:451:12: warning: assignment makes pointer from integer without a cast [enabled by default]
> >> drivers/staging/zsmalloc/zsmalloc-main.c:459:4: error: implicit declaration of function 'free_vm_area' [-Werror=implicit-function-declaration]
> >> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_map_object':
> >> drivers/staging/zsmalloc/zsmalloc-main.c:705:3: error: implicit declaration of function 'set_pte' [-Werror=implicit-function-declaration]
> >> drivers/staging/zsmalloc/zsmalloc-main.c:709:27: error: dereferencing pointer to incomplete type
> >> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_unmap_object':
> >> drivers/staging/zsmalloc/zsmalloc-main.c:739:3: error: implicit declaration of function '__flush_tlb_one' [-Werror=implicit-function-declaration]
> >>
> >> Caused by commit 61989a80fb3a ("staging: zsmalloc: zsmalloc memory
> >> allocation library"). This needs to include linux/vmalloc.h at least. I
> >> couldn't find set_pte at all or __flush_tlb_one for powerpc.
> >>
> >> This was too hard to revert, so I have left powerpc allyesconfig broken
> >> for today. I may revert it (and some dependent commits) tomorrow.
> >
> > Nitin, please send me a patch to fix this as soon as possible.
>
> Sending a patch now. Adds linux/vmalloc.h to zsmalloc-main.c. On a less ideal
> note, it also adds an X86 dependency since set_pte and __flush_tlb_one are
> x86 only. I'm working to find portable replacements for these functions.
Thanks for the patch, I'll queue it up.
greg k-h
next prev parent reply other threads:[~2012-02-13 15:03 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 6:19 linux-next: build failure after merge of the final tree (staging tree related) Stephen Rothwell
2012-02-13 6:45 ` Greg KH
2012-02-13 14:13 ` Seth Jennings
2012-02-13 14:48 ` Seth Jennings
2012-02-13 15:03 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-02-10 4:54 Stephen Rothwell
2014-02-10 5:04 ` Greg KH
2013-06-19 8:10 Stephen Rothwell
2013-06-19 9:26 ` Peng Tao
2013-06-19 14:37 ` Greg KH
2013-06-20 10:52 ` Peng Tao
2013-06-24 22:40 ` Greg KH
2013-06-24 23:40 ` Stephen Rothwell
2013-06-24 23:50 ` Greg KH
2013-06-25 0:22 ` Peng Tao
2013-06-25 2:13 ` Greg KH
2013-04-24 7:56 linux-next: build failure after merge of the final tree (staging tree related)) Stephen Rothwell
2013-04-24 17:53 ` H Hartley Sweeten
2013-04-24 18:33 ` H Hartley Sweeten
2013-03-13 5:39 linux-next: build failure after merge of the final tree (staging tree related) Stephen Rothwell
2013-03-14 20:23 ` Paul Zimmerman
2013-03-14 20:33 ` Greg KH
2013-03-06 0:35 Stephen Rothwell
2013-03-06 0:43 ` Greg KH
2013-03-06 13:56 ` Konrad Rzeszutek Wilk
2013-03-06 20:04 ` Konrad Rzeszutek Wilk
2013-03-06 20:46 ` Stephen Rothwell
2013-03-06 20:50 ` Stephen Rothwell
2013-03-06 22:23 ` Konrad Rzeszutek Wilk
2013-03-06 22:11 ` Greg KH
2013-03-06 22:21 ` Konrad Rzeszutek Wilk
2012-11-13 5:51 Stephen Rothwell
2012-11-13 9:24 ` Jonathan Cameron
2012-11-13 18:48 ` Greg KH
2012-09-24 14:29 Stephen Rothwell
2012-09-10 7:04 Stephen Rothwell
2012-09-10 17:31 ` Greg KH
2012-09-05 5:48 Stephen Rothwell
2012-09-06 18:06 ` Geert Uytterhoeven
2012-05-16 10:06 Stephen Rothwell
2012-05-16 12:49 ` Greg KH
2012-05-16 14:17 ` Dan Magenheimer
2012-05-16 15:10 ` Greg KH
2012-02-27 7:13 Stephen Rothwell
2012-02-27 21:16 ` Greg KH
2012-02-29 7:35 ` Chris Kelly
2012-02-29 7:52 ` Stephen Rothwell
2012-02-29 17:08 ` Chris Kelly
2011-10-04 8:05 Stephen Rothwell
2011-10-04 8:49 ` Jonathan Cameron
2011-08-25 6:17 Stephen Rothwell
2011-08-24 5:47 Stephen Rothwell
2011-08-24 21:16 ` Greg KH
2011-08-24 22:54 ` Stephen Rothwell
2011-08-24 22:57 ` Greg KH
2011-08-24 23:28 ` Stephen Rothwell
2011-07-18 9:36 Stephen Rothwell
2011-07-19 1:01 ` Greg KH
2011-07-28 3:35 ` Stephen Rothwell
2011-08-02 23:17 ` Greg KH
2011-07-07 6:25 Stephen Rothwell
2011-07-07 13:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120213150309.GA10009@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=sfr@canb.auug.org.au \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).