From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754076Ab2BQUak (ORCPT ); Fri, 17 Feb 2012 15:30:40 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:48883 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752125Ab2BQUaj (ORCPT ); Fri, 17 Feb 2012 15:30:39 -0500 Date: Fri, 17 Feb 2012 12:30:37 -0800 From: Andrew Morton To: Konstantin Khlebnikov Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , Sam Ravnborg Subject: Re: [PATCH] mm: add config NUMA stub to all architectures Message-Id: <20120217123037.ecfc5dd9.akpm@linux-foundation.org> In-Reply-To: <20120217120815.25909.15632.stgit@zurg> References: <4F3E42E0.4030108@openvz.org> <20120217120815.25909.15632.stgit@zurg> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Feb 2012 16:08:15 +0400 Konstantin Khlebnikov wrote: > Config NUMA must be defined for all architectures, > otherwise IS_ENABLED(CONFIG_NUMA) does not work. > Some arch-specific Kconfig already has this stub. > This patch adds it to all remaining. It would be better to teach IS_ENABLED() to handle this situation. I don't think there's a way of doing this with cpp :( This limitation makes IS_ENABLED pretty dangerous, doesn't it? It makes it very easy to introduce build breakage with unexpected Kconfig combinations.