From: Sam Ravnborg <sam@ravnborg.org>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: add config NUMA stub to all architectures
Date: Fri, 17 Feb 2012 14:44:04 +0100 [thread overview]
Message-ID: <20120217134404.GA11353@merkur.ravnborg.org> (raw)
In-Reply-To: <4F3E56DA.3050203@openvz.org>
On Fri, Feb 17, 2012 at 05:32:10PM +0400, Konstantin Khlebnikov wrote:
> Stephen Rothwell wrote:
>> Hi Konstantin,
>>
>> On Fri, 17 Feb 2012 16:08:15 +0400 Konstantin Khlebnikov<khlebnikov@openvz.org> wrote:
>>>
>>> Config NUMA must be defined for all architectures,
>>> otherwise IS_ENABLED(CONFIG_NUMA) does not work.
>>> Some arch-specific Kconfig already has this stub.
>>> This patch adds it to all remaining.
>>
>> Why not add it somewhere generic (like mm/Kconfig, maybe) and then it can
>> be removed from the architecture specific places over time (if necessary
>> - I am pretty sure it is ok to have it there twice)?
>>
>
> Different architectures has different dependencies for NUMA.
>
> Seems like Kconfig allow config option duplication, but it use default state from first.
> If we add "config NUMA\n def_bool n" somewhere in generic Kconfig, default will be n if
> Kconfig see this declaration first.
Correct.
And as n is default there is no need to specify it.
But please add a help text that explain the symbol - even if it is not
visible in menuconfig.
Sam
next prev parent reply other threads:[~2012-02-17 13:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 10:20 linux-next: build failure after merge of the final tree (akpm tree related) Stephen Rothwell
2012-02-17 12:06 ` Konstantin Khlebnikov
2012-02-17 12:08 ` [PATCH] mm: add config NUMA stub to all architectures Konstantin Khlebnikov
2012-02-17 12:45 ` Stephen Rothwell
2012-02-17 13:32 ` Konstantin Khlebnikov
2012-02-17 13:44 ` Sam Ravnborg [this message]
2012-02-17 23:39 ` Stephen Rothwell
2012-02-17 20:30 ` Andrew Morton
2012-02-19 17:01 ` Geert Uytterhoeven
2012-02-19 18:12 ` Randy Dunlap
2012-02-19 23:21 ` Arnaud Lacombe
2012-02-20 14:24 ` Michal Marek
2012-02-19 23:04 ` linux-next: build failure after merge of the final tree (akpm tree related) Stephen Rothwell
2012-02-19 23:15 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217134404.GA11353@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).