From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Rabin Vincent <rabin@rab.in>
Cc: linux-arm-kernel@lists.infradead.org,
Jason Baron <jbaron@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 5/6] jump label: detect %c support for ARM
Date: Mon, 20 Feb 2012 17:21:58 +0000 [thread overview]
Message-ID: <20120220172158.GI26840@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1327757725-10114-6-git-send-email-rabin@rab.in>
On Sat, Jan 28, 2012 at 07:05:24PM +0530, Rabin Vincent wrote:
> Some versions of ARM GCC which do support asm goto, have problems
> handling the the %c specifier. Since we need the %c to support jump
> labels on ARM, detect that too in the asm goto detection script to avoid
> build errors with these versions.
I'm not sure how this detects properly working %c support. %c support
has been rather flakey on ARM for some time, I'm not sure which version
of gcc was fixed for it.
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48637
>
> Cc: Jason Baron <jbaron@redhat.com>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Rabin Vincent <rabin@rab.in>
> ---
> scripts/gcc-goto.sh | 18 +++++++++++++++++-
> 1 files changed, 17 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/gcc-goto.sh b/scripts/gcc-goto.sh
> index 98cffcb..9b744de 100644
> --- a/scripts/gcc-goto.sh
> +++ b/scripts/gcc-goto.sh
> @@ -2,4 +2,20 @@
> # Test for gcc 'asm goto' support
> # Copyright (C) 2010, Jason Baron <jbaron@redhat.com>
>
> -echo "int main(void) { entry: asm goto (\"\"::::entry); return 0; }" | $@ -x c - -c -o /dev/null >/dev/null 2>&1 && echo "y"
> +cat << "END" | $@ -x c - -c -o /dev/null >/dev/null 2>&1 && echo "y"
> +int main(void)
> +{
> +#ifdef __arm__
> + /*
> + * Not related to asm goto, but used by jump label
> + * and broken on some ARM GCC versions (see GCC Bug 48637).
> + */
> + static struct { int dummy; int state; } tp;
> + asm ("@ %c0" :: "i" (&tp.state));
While this detects the presence of the ICE, previous compilers included
the '#' before the constant, which leads to problems. I think a better
check would be:
asm(".long %c0" :: "i" (&tp.state));
to make sure that it spits out something purely numeric, rather than
something prefixed with a '#'.
next prev parent reply other threads:[~2012-02-20 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1327757725-10114-1-git-send-email-rabin@rab.in>
2012-01-28 13:35 ` [PATCHv2 5/6] jump label: detect %c support for ARM Rabin Vincent
2012-02-07 16:18 ` Rabin Vincent
2012-02-07 18:04 ` Jason Baron
2012-02-20 17:21 ` Russell King - ARM Linux [this message]
2012-02-22 13:32 ` Rabin Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120220172158.GI26840@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=jbaron@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rabin@rab.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).