From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754143Ab2BTVK1 (ORCPT ); Mon, 20 Feb 2012 16:10:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52700 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753815Ab2BTVKZ (ORCPT ); Mon, 20 Feb 2012 16:10:25 -0500 Date: Mon, 20 Feb 2012 16:10:20 -0500 From: Vivek Goyal To: Tejun Heo Cc: Kent Overstreet , axboe@kernel.dk, ctalbott@google.com, rni@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/9] block: implement bio_associate_current() Message-ID: <20120220211020.GE13423@redhat.com> References: <20120217011907.GA15073@google.com> <20120217221406.GJ29414@google.com> <20120217223420.GJ26620@redhat.com> <20120217224103.GN29414@google.com> <20120217225125.GK26620@redhat.com> <20120217225735.GP29414@google.com> <20120220143622.GB10342@redhat.com> <20120220170128.GB7836@mtj.dyndns.org> <20120220191604.GC13423@redhat.com> <20120220210642.GC3538@dhcp-172-17-108-109.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120220210642.GC3538@dhcp-172-17-108-109.mtv.corp.google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 20, 2012 at 01:06:42PM -0800, Tejun Heo wrote: > Hello, > > On Mon, Feb 20, 2012 at 02:16:04PM -0500, Vivek Goyal wrote: > > On Mon, Feb 20, 2012 at 09:01:28AM -0800, Tejun Heo wrote: > > > Yeah, AFAICS, if the cloning task hasn't issued IO before, CLONE_IO is > > > ignored. > > > > Will it make sense to try to allocate and attach io_context and then > > share it in copy_io()? > > Yeap, that's probably what we should do on CLONE_IO. > > > Well, you are planning to kill CLONE_IO altogether, so it does not > > make a difference. > > Heh, I was just thinking about sending out a RFC patch. I mean, > CLONE_IO handling that severely broken and nobody noticing for such > long time doesn't look good, right? Yep, it definitely raises the question that how many users are out there. Thanks Vivek