From: Jan Kara <jack@suse.cz>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: Jan Kara <jack@suse.cz>, LKML <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Eric Sandeen <sandeen@redhat.com>,
Dave Chinner <david@fromorbit.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 10/11] nfs: Push file_update_time() into nfs_vm_page_mkwrite()
Date: Mon, 20 Feb 2012 23:32:54 +0100 [thread overview]
Message-ID: <20120220223254.GC32708@quack.suse.cz> (raw)
In-Reply-To: <1329400219.2924.1.camel@lade.trondhjem.org>
On Thu 16-02-12 13:50:19, Myklebust, Trond wrote:
> On Thu, 2012-02-16 at 14:46 +0100, Jan Kara wrote:
> > CC: Trond Myklebust <Trond.Myklebust@netapp.com>
> > CC: linux-nfs@vger.kernel.org
> > Signed-off-by: Jan Kara <jack@suse.cz>
> > ---
> > fs/nfs/file.c | 3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/fs/nfs/file.c b/fs/nfs/file.c
> > index c43a452..2407922 100644
> > --- a/fs/nfs/file.c
> > +++ b/fs/nfs/file.c
> > @@ -525,6 +525,9 @@ static int nfs_vm_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf)
> > /* make sure the cache has finished storing the page */
> > nfs_fscache_wait_on_page_write(NFS_I(dentry->d_inode), page);
> >
> > + /* Update file times before taking page lock */
> > + file_update_time(filp);
> > +
> > lock_page(page);
> > mapping = page->mapping;
> > if (mapping != dentry->d_inode->i_mapping)
>
> Hi Jan,
>
> file_update_time() is a no-op in NFS, since we set S_NOATIME|S_NOCMTIME
> on all inodes.
Thanks. I've discarded the patch.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2012-02-20 22:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 13:46 [PATCH 00/11] Push file_update_time() into .page_mkwrite Jan Kara
2012-02-16 13:46 ` [PATCH 01/11] perf: Push file_update_time() into perf_mmap_fault() Jan Kara
2012-02-16 13:50 ` Peter Zijlstra
2012-02-20 22:33 ` Jan Kara
2012-02-16 13:46 ` [PATCH 02/11] fb_defio: Push file_update_time() into fb_deferred_io_mkwrite() Jan Kara
2012-02-16 13:46 ` [PATCH 03/11] fs: Push file_update_time() into __block_page_mkwrite() Jan Kara
2012-02-16 13:46 ` [PATCH 04/11] ceph: Push file_update_time() into ceph_page_mkwrite() Jan Kara
2012-02-16 19:04 ` Alex Elder
2012-02-16 19:13 ` Sage Weil
2012-02-20 22:42 ` Jan Kara
2012-02-20 22:57 ` Sage Weil
2012-02-20 11:06 ` Jan Kara
2012-02-16 13:46 ` [PATCH 05/11] cifs: Push file_update_time() into cifs_page_mkwrite() Jan Kara
2012-02-16 13:46 ` [PATCH 06/11] 9p: Push file_update_time() into v9fs_vm_page_mkwrite() Jan Kara
2012-02-16 13:46 ` [PATCH 07/11] fuse: Push file_update_time() into fuse_page_mkwrite() Jan Kara
2012-02-16 13:46 ` [PATCH 08/11] gfs2: Push file_update_time() into gfs2_page_mkwrite() Jan Kara
2012-02-16 16:47 ` Steven Whitehouse
2012-02-16 13:46 ` [PATCH 09/11] sysfs: Push file_update_time() into bin_page_mkwrite() Jan Kara
2012-02-16 16:24 ` Greg Kroah-Hartman
2012-02-16 19:04 ` Alex Elder
2012-02-20 11:00 ` Jan Kara
2012-02-29 17:46 ` Eric W. Biederman
2012-02-16 13:46 ` [PATCH 10/11] nfs: Push file_update_time() into nfs_vm_page_mkwrite() Jan Kara
2012-02-16 13:50 ` Myklebust, Trond
2012-02-20 22:32 ` Jan Kara [this message]
2012-02-16 13:46 ` [PATCH 11/11] mm: Update file times from fault path only if .page_mkwrite is not set Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120220223254.GC32708@quack.suse.cz \
--to=jack@suse.cz \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).