From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754734Ab2BTWmu (ORCPT ); Mon, 20 Feb 2012 17:42:50 -0500 Received: from cantor2.suse.de ([195.135.220.15]:41461 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754593Ab2BTWms (ORCPT ); Mon, 20 Feb 2012 17:42:48 -0500 Date: Mon, 20 Feb 2012 23:42:45 +0100 From: Jan Kara To: Sage Weil Cc: Alex Elder , Jan Kara , LKML , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Eric Sandeen , Dave Chinner , ceph-devel@vger.kernel.org Subject: Re: [PATCH 04/11] ceph: Push file_update_time() into ceph_page_mkwrite() Message-ID: <20120220224245.GE32708@quack.suse.cz> References: <1329399979-3647-1-git-send-email-jack@suse.cz> <1329399979-3647-5-git-send-email-jack@suse.cz> <1329419077.3121.38.camel@doink> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 16-02-12 11:13:53, Sage Weil wrote: > On Thu, 16 Feb 2012, Alex Elder wrote: > > On Thu, 2012-02-16 at 14:46 +0100, Jan Kara wrote: > > > CC: Sage Weil > > > CC: ceph-devel@vger.kernel.org > > > Signed-off-by: Jan Kara > > > > > > This will update the timestamp even if a write > > fault fails, which is different from before. > > > > Hard to avoid though. > > > > Looks good to me. > > Yeah. Let's put something in the tracker to take a look later (I think we > can do better), but this is okay for now. > > Signed-off-by: Sage Weil Thanks! Just an administrative note - the tag above should rather be Acked-by or Reviewed-by. You'd use Signed-off-by only if you took the patch and merged it via your tree... So can I add Acked-by? Honza > > Signed-off-by: Alex Elder > > > > > fs/ceph/addr.c | 3 +++ > > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > > > > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c > > > index 173b1d2..12b139f 100644 > > > --- a/fs/ceph/addr.c > > > +++ b/fs/ceph/addr.c > > > @@ -1181,6 +1181,9 @@ static int ceph_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) > > > loff_t size, len; > > > int ret; > > > > > > + /* Update time before taking page lock */ > > > + file_update_time(vma->vm_file); > > > + > > > size = i_size_read(inode); > > > if (off + PAGE_CACHE_SIZE <= size) > > > len = PAGE_CACHE_SIZE; > > > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- Jan Kara SUSE Labs, CR