From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ram Pai <linuxram@us.ibm.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] PCI: Make pci bridge reallocating enabled/disabled
Date: Thu, 23 Feb 2012 11:57:47 -0800 [thread overview]
Message-ID: <20120223115747.4b85fdb2@jbarnes-desktop> (raw)
In-Reply-To: <1328916832-6588-6-git-send-email-yinghai@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 573 bytes --]
On Fri, 10 Feb 2012 15:33:50 -0800
Yinghai Lu <yinghai@kernel.org> wrote:
> +enum enable_type {
> + enable_not_set = -1,
> + enable_no_user,
> + enable_no_detected,
> + enable_yes_user,
> + enable_yes_detected,
> +};
How about:
user_enabled
user_disabled
auto_enabled
auto_disabled
?
enable_no_* seems a bit confusing...
also the help text in kernel-parameters.txt should mention the config
option and describe default behavior with and without that config
option enabled.
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-23 19:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 23:33 [PATCH -v3 0/7] PCI : bridge resource reallocation patchset -- followup Yinghai Lu
2012-02-10 23:33 ` [PATCH 1/7] PCI: Disable cardbus bridge MEM1 pref CTL Yinghai Lu
2012-02-10 23:33 ` [PATCH 2/7] PCI: Fix cardbus bridge resources as optional size handling Yinghai Lu
2012-02-10 23:33 ` [PATCH 3/7] PCI: Skip reset cardbus assigned resource during pci bus rescan Yinghai Lu
2012-02-23 19:58 ` Jesse Barnes
2012-02-10 23:33 ` [PATCH 4/7] PCI: Retry on type IORESOURCE_IO allocation Yinghai Lu
2012-02-23 19:54 ` Jesse Barnes
2012-02-10 23:33 ` [PATCH 5/7] PCI: Make pci bridge reallocating enabled/disabled Yinghai Lu
2012-02-23 19:57 ` Jesse Barnes [this message]
2012-02-10 23:33 ` [PATCH 6/7] PCI: print out suggestion about using pci=realloc Yinghai Lu
2012-02-10 23:33 ` [PATCH 7/7] PCI: only enable pci realloc when SRIOV bar is not assigned Yinghai Lu
-- strict thread matches above, loose matches on Subject: below --
2012-02-01 22:42 [PATCH 0/7] PCI : bridge resource reallocation patchset -- followup Yinghai Lu
2012-02-01 22:42 ` [PATCH 5/7] PCI: Make pci bridge reallocating enabled/disabled Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120223115747.4b85fdb2@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=linuxram@us.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).