linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jorgyano Vieira <jorgyano@gmail.com>
Cc: devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
	nsankar@broadcom.com, jarod@wilsonet.com
Subject: Re: [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err
Date: Fri, 24 Feb 2012 11:49:29 -0800	[thread overview]
Message-ID: <20120224194929.GA24613@kroah.com> (raw)
In-Reply-To: <1329603020-5302-1-git-send-email-jorgyano@gmail.com>

On Sat, Feb 18, 2012 at 08:10:20PM -0200, Jorgyano Vieira wrote:
> Replace the usage of BCMLOG_ERR with pr_err and remove the macro definition.
> Also added pr_fmt to identify the driver error messages.
> 
> Signed-ff-by: Jorgyano Vieira <jorgyano@gmail.com>
> ---
>  drivers/staging/crystalhd/crystalhd_cmds.c |   68 ++++++++--------
>  drivers/staging/crystalhd/crystalhd_hw.c   |  119 ++++++++++++++--------------
>  drivers/staging/crystalhd/crystalhd_lnx.c  |   96 +++++++++++-----------
>  drivers/staging/crystalhd/crystalhd_lnx.h  |    4 +-
>  drivers/staging/crystalhd/crystalhd_misc.c |   70 ++++++++--------
>  drivers/staging/crystalhd/crystalhd_misc.h |   10 +--
>  6 files changed, 181 insertions(+), 186 deletions(-)
> 
> diff --git a/drivers/staging/crystalhd/crystalhd_cmds.c b/drivers/staging/crystalhd/crystalhd_cmds.c
> index 3735ed3..46fac01 100644
> --- a/drivers/staging/crystalhd/crystalhd_cmds.c
> +++ b/drivers/staging/crystalhd/crystalhd_cmds.c
> @@ -75,12 +75,12 @@ static enum BC_STATUS bc_cproc_notify_mode(struct crystalhd_cmd *ctx,
>  	int rc = 0, i = 0;
>  
>  	if (!ctx || !idata) {
> -		BCMLOG_ERR("Invalid Arg!!\n");
> +		pr_err("%s: Invalid Arg!!\n", __func__);

This is nice, but, as this is a driver, I really prefer the use of
dev_err() instead, which allows us to properly identify the device and
driver that spit out the error message.  Care to redo this patch in that
style instead?

thanks,

greg k-h

  parent reply	other threads:[~2012-02-24 19:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-18 22:10 [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err Jorgyano Vieira
2012-02-18 22:31 ` Joe Perches
2012-02-18 23:08   ` Jorgyano vieira
2012-02-18 23:14     ` Joe Perches
2012-02-18 23:34       ` Jorgyano vieira
2012-02-18 23:45         ` Joe Perches
2012-02-24 19:49 ` Greg KH [this message]
2012-02-25  5:23   ` Jorgyano vieira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120224194929.GA24613@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@linuxdriverproject.org \
    --cc=jarod@wilsonet.com \
    --cc=jorgyano@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nsankar@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).