From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755791Ab2B0WHt (ORCPT <rfc822;w@1wt.eu>);
	Mon, 27 Feb 2012 17:07:49 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:47133 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755349Ab2B0WHs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 27 Feb 2012 17:07:48 -0500
Date: Mon, 27 Feb 2012 14:07:46 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: David Daney <ddaney.cavm@gmail.com>
Cc: Venkatesh Pallipadi <venki@google.com>,
        KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
        KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
        Mike Travis <travis@sgi.com>,
        "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
        "Paul E. McKenney" <paul.mckenney@linaro.org>,
        "Rafael J. Wysocki" <rjw@sisk.pl>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Avoid mask based num_possible_cpus and num_online_cpus
 -v5
Message-Id: <20120227140746.61f5fba9.akpm@linux-foundation.org>
In-Reply-To: <4F4BFBEB.8080800@gmail.com>
References: <CABeCy1aPp4=v90v_wAsw-KWDwNs59CwwYSJ-36+4t8kMuCaK0w@mail.gmail.com>
	<1328055439-9441-1-git-send-email-venki@google.com>
	<4F4BFBEB.8080800@gmail.com>
X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 27 Feb 2012 13:55:55 -0800
David Daney <ddaney.cavm@gmail.com> wrote:

> On 01/31/2012 04:17 PM, Venkatesh Pallipadi wrote:
> > Kernel's notion of possible cpus (from include/linux/cpumask.h)
> >   *     cpu_possible_mask- has bit 'cpu' set iff cpu is populatable
> >
> >   *  The cpu_possible_mask is fixed at boot time, as the set of CPU id's
> >   *  that it is possible might ever be plugged in at anytime during the
> >   *  life of that system boot.
> >
> >   #define num_possible_cpus()     cpumask_weight(cpu_possible_mask)
> >
> > and on x86 cpumask_weight() calls hweight64 and hweight64 (on older kernels
> > and systems with !X86_FEATURE_POPCNT) or a popcnt based alternative.
> >
> > i.e, We needlessly go through this mask based calculation everytime
> > num_possible_cpus() is called.
> >
> > The problem is there with cpu_online_mask() as well, which is fixed value at
> > boot time in !CONFIG_HOTPLUG_CPU case and should not change that often even
> > in HOTPLUG case.
> >
> > Though most of the callers of these two routines are init time (with few
> > exceptions of runtime calls), it is cleaner to use variables
> > and not go through this repeated mask based calculation.
> >
> > Signed-off-by: Venkatesh Pallipadi<venki@google.com>
> > Acked-by: Srivatsa S. Bhat<srivatsa.bhat@linux.vnet.ibm.com>
> > Acked-by: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com>
> 
> How is it that this patch got merged to linux-next before all the 
> cleanup patches for nr_online_cpus?

<spends five minutes searching mailing list archives>

I for one do not have a clue what patches the term "cleanup patches for
nr_online_cpus" refers to.  Patches have names - please use them!

>  From the looks of your follow-on patches it would seem that all MIPS, 
> hexagon, and um are now broken.
> 
> I know for a fact that MIPS doesn't boot because of this.

I shall drop
cpumask-avoid-mask-based-num_possible_cpus-and-num_online_cpus.patch.

That patch was sent as a single standalone patch and the changelog had
no mention of any needed preparatory patches.  If resending, please
send *all* patches in a single sequence-numbered series.  We know how
to do this.