From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Konstantin Khlebnikov <khlebnikov@openvz.org>,
Michal Hocko <mhocko@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/2] kernel: cgroup: push rcu read locking from css_is_ancestor() to callsite
Date: Wed, 29 Feb 2012 09:00:05 +0900 [thread overview]
Message-ID: <20120229090005.1ef4cdb2.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <1330438489-21909-1-git-send-email-hannes@cmpxchg.org>
On Tue, 28 Feb 2012 15:14:48 +0100
Johannes Weiner <hannes@cmpxchg.org> wrote:
> Library functions should not grab locks when the callsites can do it,
> even if the lock nests like the rcu read-side lock does.
>
> Push the rcu_read_lock() from css_is_ancestor() to its single user,
> mem_cgroup_same_or_subtree() in preparation for another user that may
> already hold the rcu read-side lock.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
next prev parent reply other threads:[~2012-02-29 0:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 14:14 [patch 1/2] kernel: cgroup: push rcu read locking from css_is_ancestor() to callsite Johannes Weiner
2012-02-28 14:14 ` [patch 2/2] mm: memcg: count pte references from every member of the reclaimed hierarchy Johannes Weiner
2012-02-28 15:46 ` Konstantin Khlebnikov
2012-02-29 0:39 ` KAMEZAWA Hiroyuki
2012-02-29 2:02 ` Johannes Weiner
2012-02-29 3:08 ` KAMEZAWA Hiroyuki
2012-03-14 14:25 ` Michal Hocko
2012-03-14 16:21 ` Johannes Weiner
2012-03-14 17:53 ` Michal Hocko
2012-03-14 17:54 ` Michal Hocko
2012-02-29 0:00 ` KAMEZAWA Hiroyuki [this message]
2012-03-01 1:38 ` [patch 1/2] kernel: cgroup: push rcu read locking from css_is_ancestor() to callsite Li Zefan
2012-03-14 12:41 ` Michal Hocko
2012-04-24 19:35 Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229090005.1ef4cdb2.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=hannes@cmpxchg.org \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).