linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Dooks <ben-i2c@fluff.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Zhao Chenhui <chenhui.zhao@freescale.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	Li Yang <leoli@freescale.com>
Subject: Re: [PATCH] i2c-mpc: avoid I2C abnormal after resuming from deep sleep
Date: Thu, 1 Mar 2012 11:27:24 +0000	[thread overview]
Message-ID: <20120301112724.GE8441@trinity.fluff.org> (raw)
In-Reply-To: <20120229183436.GA30545@pengutronix.de>

On Wed, Feb 29, 2012 at 07:45:23PM +0100, Wolfram Sang wrote:
> Hi,
> 
> On Wed, Feb 29, 2012 at 06:39:21PM +0800, Zhao Chenhui wrote:
> > When entering deep sleep, the value in the registers I2CFDR and
> > I2CDFSRR are lost. This causes I2C access to fail after resuming.
> > 
> > Add suspend/resume routines to save/restore the registers
> > I2CFDR and I2CDFSRR.
> > 
> > Signed-off-by: Zhao Chenhui <chenhui.zhao@freescale.com>
> > Signed-off-by: Li Yang <leoli@freescale.com>
> > ---
> >  drivers/i2c/busses/i2c-mpc.c |   34 +++++++++++++++++++++++++++++++++-
> >  1 files changed, 33 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
> > index a8ebb84..f95a647 100644
> > --- a/drivers/i2c/busses/i2c-mpc.c
> > +++ b/drivers/i2c/busses/i2c-mpc.c
> > @@ -1,7 +1,9 @@
> >  /*
> >   * (C) Copyright 2003-2004
> >   * Humboldt Solutions Ltd, adrian@humboldt.co.uk.
> > -
> > + *
> > + * Copyright 2012 Freescale Semiconductor, Inc.
> > + *
> 
> I'd think the change is too trivial to claim copyright on the file.

I agree with that.

-- 
Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.


  reply	other threads:[~2012-03-01 12:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29 10:39 [PATCH] i2c-mpc: avoid I2C abnormal after resuming from deep sleep Zhao Chenhui
2012-02-29 13:02 ` Shubhrajyoti Datta
2012-02-29 18:08   ` Tabi Timur-B04825
2012-02-29 18:45 ` Wolfram Sang
2012-03-01 11:27   ` Ben Dooks [this message]
2012-04-17 14:21   ` Wolfram Sang
2012-04-18 10:20     ` Li Yang-R58472
2012-04-18 10:33       ` Wolfram Sang
2012-04-18 14:44         ` Li Yang
2012-04-18 21:49           ` Tabi Timur-B04825

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120301112724.GE8441@trinity.fluff.org \
    --to=ben-i2c@fluff.org \
    --cc=chenhui.zhao@freescale.com \
    --cc=leoli@freescale.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).