From: Minchan Kim <minchan@kernel.org>
To: Satoru Moriya <satoru.moriya@hds.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rik van Riel <riel@redhat.com>,
"lwoodman@redhat.com" <lwoodman@redhat.com>,
"jweiner@redhat.com" <jweiner@redhat.com>,
"shaohua.li@intel.com" <shaohua.li@intel.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
"dle-develop@lists.sourceforge.net"
<dle-develop@lists.sourceforge.net>,
Seiji Aguchi <seiji.aguchi@hds.com>
Subject: Re: [RFC][PATCH] avoid swapping out with swappiness==0
Date: Sun, 4 Mar 2012 15:57:59 +0900 [thread overview]
Message-ID: <20120304065759.GA7824@barrios> (raw)
In-Reply-To: <65795E11DBF1E645A09CEC7EAEE94B9CB9455FE2@USINDEVS02.corp.hds.com>
Hi Satoru,
On Fri, Mar 02, 2012 at 12:36:40PM -0500, Satoru Moriya wrote:
> Sometimes we'd like to avoid swapping out anonymous memory
> in particular, avoid swapping out pages of important process or
> process groups while there is a reasonable amount of pagecache
> on RAM so that we can satisfy our customers' requirements.
>
> OTOH, we can control how aggressive the kernel will swap memory pages
> with /proc/sys/vm/swappiness for global and
> /sys/fs/cgroup/memory/memory.swappiness for each memcg.
>
> But with current reclaim implementation, the kernel may swap out
> even if we set swappiness==0 and there is pagecache on RAM.
>
> This patch changes the behavior with swappiness==0. If we set
> swappiness==0, the kernel does not swap out completely
> (for global reclaim until the amount of free pages and filebacked
> pages in a zone has been reduced to something very very small
> (nr_free + nr_filebacked < high watermark)).
>
> Any comments are welcome.
>
> Regards,
> Satoru Moriya
>
> Signed-off-by: Satoru Moriya <satoru.moriya@hds.com>
Acked-by: Minchan Kim <minchan@kernel.org>
I agree this feature but current code is rather ugly on readbility.
It's not your fault because it is caused by adding 'noswap' to avoid
scanning of anon pages when priority is 0. You just used that code. :)
Hillf's version looks to be much clean refactoring so after we merge
your patch, we can tidy it up with Hillf's patch.
next prev parent reply other threads:[~2012-03-04 6:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 17:36 [RFC][PATCH] avoid swapping out with swappiness==0 Satoru Moriya
2012-03-02 22:47 ` Rik van Riel
2012-03-02 23:43 ` Satoru Moriya
2012-03-03 2:29 ` Hillf Danton
2012-03-04 6:57 ` Minchan Kim [this message]
2012-03-05 21:38 ` Satoru Moriya
2012-03-05 13:49 ` Rik van Riel
2012-03-05 21:56 ` Johannes Weiner
2012-03-07 17:19 ` KOSAKI Motohiro
2012-03-07 18:18 ` Satoru Moriya
2012-03-30 22:44 ` Satoru Moriya
2012-04-02 17:10 ` KOSAKI Motohiro
2012-04-03 11:25 ` Jerome Marchand
2012-04-03 15:15 ` Satoru Moriya
2012-04-04 17:38 ` KOSAKI Motohiro
2012-04-21 0:21 ` Satoru Moriya
2012-05-11 21:11 ` Satoru Moriya
2012-05-12 22:21 ` Rik van Riel
2012-04-24 8:20 ` Richard Davies
2012-04-24 22:14 ` Satoru Moriya
2012-04-26 14:26 ` Richard Davies
2012-04-26 15:41 ` KOSAKI Motohiro
2012-05-07 20:09 ` Rik van Riel
2012-05-08 0:05 ` Minchan Kim
2012-05-21 7:12 ` Richard Davies
2012-05-21 13:39 ` Satoru Moriya
2012-04-26 14:50 ` Christoph Lameter
2012-04-26 15:37 ` KOSAKI Motohiro
2012-04-26 16:08 ` Richard Davies
2012-04-26 18:20 ` Christoph Lameter
2012-04-27 13:55 ` Rik van Riel
2012-05-07 20:11 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120304065759.GA7824@barrios \
--to=minchan@kernel.org \
--cc=dle-develop@lists.sourceforge.net \
--cc=jweiner@redhat.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lwoodman@redhat.com \
--cc=riel@redhat.com \
--cc=satoru.moriya@hds.com \
--cc=seiji.aguchi@hds.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).