linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Jeff Garzik <jgarzik@pobox.com>
Subject: Re: linux-next: build failure after merge of the scsi tree
Date: Fri, 23 Mar 2012 20:24:14 +1100	[thread overview]
Message-ID: <20120323202414.12bc2529aa4cb5b8e781878d@canb.auug.org.au> (raw)
In-Reply-To: <1332490809.2801.2.camel@dabdike.int.hansenpartnership.com>

[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]

Hi James,

On Fri, 23 Mar 2012 08:20:09 +0000 James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
>
> On Fri, 2012-03-23 at 13:00 +1100, Stephen Rothwell wrote:
> > 
> > After merging the scsi tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > drivers/ata/sata_svw.c: In function 'k2_sata_proc_open':
> > drivers/ata/sata_svw.c:327:2: error: implicit declaration of function 'PDE' [-Werror=implicit-function-declaration]
> > drivers/ata/sata_svw.c:327:56: error: invalid type argument of '->' (have 'int')
> > drivers/ata/sata_svw.c:328:1: warning: control reaches end of non-void function [-Wreturn-type]
> 
> That's defined in linux/proc_fs.h
> 
> What was the config?  Was it a no-PROCFS config, or is this just
> something that needs to be explicitly included?

See above, that was a powerpc ppc64_defconfig.  It certainly has PROCFS
enabled.  Almost everything needs to be explicitly included - see Rule 1
in Documentation/SubmitChecklist ...

Implicit includes are vulnerable to CONFIG changes and
architecture/platform differences in the include files.  I have seen lots
of these.  :-(

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-03-23  9:24 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-23  2:00 linux-next: build failure after merge of the scsi tree Stephen Rothwell
2012-03-23  4:50 ` Benjamin Herrenschmidt
2012-03-23  8:14   ` James Bottomley
2012-03-23  8:53     ` Benjamin Herrenschmidt
2012-03-23  9:01       ` James Bottomley
2012-03-23 15:22         ` Jeff Garzik
2012-03-23 10:26   ` Alexey Dobriyan
2012-03-23 15:30     ` Jeff Garzik
2012-03-23  8:20 ` James Bottomley
2012-03-23  9:24   ` Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-03-20  0:48 Stephen Rothwell
2017-08-28  8:02 Stephen Rothwell
2017-02-06  5:04 Stephen Rothwell
2017-02-13  0:32 ` Stephen Rothwell
2017-02-13 16:18   ` Jens Axboe
2016-12-23  0:45 Stephen Rothwell
2016-12-23  0:56 ` James Bottomley
     [not found]   ` <20161224123853.08284e8a@canb.auug.org.au>
2016-12-24 10:15     ` Ingo Molnar
2016-12-24 10:44       ` Stephen Rothwell
2016-12-24 11:46     ` Thomas Gleixner
2016-12-24 16:48       ` James Bottomley
2015-11-13  1:35 Stephen Rothwell
2015-11-13  8:32 ` Sreekanth Reddy
2015-06-02  8:06 Stephen Rothwell
2015-06-02 15:02 ` James Bottomley
2015-02-04  6:29 Stephen Rothwell
2015-02-04  6:47 ` Joe Perches
2015-02-04 15:26 ` James Bottomley
2014-11-10  6:15 Stephen Rothwell
2014-11-10  6:27 ` Anish Bhatt
2014-11-10 13:46   ` Christoph Hellwig
2014-11-10 15:21     ` James Bottomley
2014-11-10 15:48       ` Christoph Hellwig
2014-11-10 15:50         ` James Bottomley
2014-11-10 16:01           ` Christoph Hellwig
2014-11-04  4:43 Stephen Rothwell
2014-11-04  7:07 ` Hannes Reinecke
2014-11-05  4:48   ` Stephen Rothwell
2014-11-03  2:52 Stephen Rothwell
2014-11-03  7:51 ` Hannes Reinecke
2014-11-03 18:31   ` Christoph Hellwig
2014-09-26  8:34 Stephen Rothwell
2014-09-26  8:36 ` Christoph Hellwig
2014-09-26  9:57   ` James Bottomley
2014-09-26 12:43     ` Brian King
2013-01-12  2:23 wenxiong
2013-01-11  1:03 Stephen Rothwell
2013-01-11  7:34 ` James Bottomley
2013-01-11 15:27   ` Brian King
2013-01-11 15:37     ` James Bottomley
2013-01-11 16:05       ` Greg KH
2013-01-11 17:35         ` Brian King
2013-01-11 18:04           ` James Bottomley
2012-07-20  0:41 Stephen Rothwell
2012-07-20  8:50 ` James Bottomley
2012-03-26  1:17 Stephen Rothwell
2012-03-26  7:57 ` James Bottomley
2012-03-26 14:07   ` Greg KH
2012-03-27  7:29     ` James Bottomley
2012-03-27 22:17     ` Alexey Dobriyan
2012-03-27 22:22       ` Greg KH
2012-03-27 22:35         ` Alexey Dobriyan
2012-03-27 22:39           ` Alexey Dobriyan
2012-03-28 23:54             ` Greg KH
2012-03-29 19:38             ` Greg KH
2012-03-28 23:52           ` Greg KH
2012-03-29  7:32             ` Gerard Snitselaar
2012-03-29  8:25               ` Stephen Rothwell
2012-03-29  8:35                 ` James Bottomley
2012-03-29  9:03                 ` Gerard Snitselaar
2012-03-29 16:15                   ` Greg KH
2011-12-15  1:58 Stephen Rothwell
2011-12-15  6:53 ` James Bottomley
2011-08-29  2:09 Stephen Rothwell
2011-08-29  7:17 ` James Bottomley
2011-08-29  8:07   ` Giridhar Malavali
2011-05-27  3:25 Stephen Rothwell
2011-05-27 13:47 ` James Bottomley
2010-10-26  0:19 Stephen Rothwell
2010-10-26 15:50 ` James Bottomley
2010-02-10  1:33 Stephen Rothwell
2010-02-10 22:16 ` James Bottomley
2010-02-10 23:11   ` Stephen Rothwell
2010-02-16  0:38   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120323202414.12bc2529aa4cb5b8e781878d@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=adobriyan@gmail.com \
    --cc=benh@kernel.crashing.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).