From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, Jiri Olsa <jolsa@redhat.com>,
Lin Ming <ming.m.lin@intel.com>, rostedt <rostedt@goodmis.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf, p4: Add format attributes
Date: Tue, 27 Mar 2012 18:57:28 +0400 [thread overview]
Message-ID: <20120327145728.GE11875@moon> (raw)
In-Reply-To: <1332859842.16159.227.camel@twins>
On Tue, Mar 27, 2012 at 04:50:42PM +0200, Peter Zijlstra wrote:
> Subject: perf, p4: Add format attributes
> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date: Tue Mar 27 16:19:25 CEST 2012
>
> Steven reported his P4 not booting properly, the missing format
> attributes cause a NULL ptr deref. Cure this by adding the missing
> format specification.
>
> I took the format description out of the comment near
> p4_config_pack*() and hope that comment is still relatively
> accurate.
>
> Cc: Cyrill Gorcunov <gorcunov@openvz.org>
> Cc: Lin Ming <ming.m.lin@intel.com>
> Reported-by: Steven Rostedt <rostedt@goodmis.org>
> Tested-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Thanks a lot, Peter! This format description is somewhat
new to me (I think I've missed when it was introduced first
time).
Reviewed-by: Cyrill Gorcunov <gorcunov@openvz.org>
Cyrill
next prev parent reply other threads:[~2012-03-27 14:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 14:50 [PATCH] perf, p4: Add format attributes Peter Zijlstra
2012-03-27 14:57 ` Cyrill Gorcunov [this message]
2012-03-27 15:05 ` Cyrill Gorcunov
2012-03-27 15:05 ` Peter Zijlstra
2012-03-27 15:07 ` Peter Zijlstra
2012-03-27 15:12 ` Cyrill Gorcunov
2012-03-27 22:03 ` Cyrill Gorcunov
2012-03-27 22:05 ` Peter Zijlstra
2012-03-27 22:11 ` Cyrill Gorcunov
2012-04-03 8:11 ` [tip:perf/urgent] perf/x86/p4: " tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120327145728.GE11875@moon \
--to=gorcunov@openvz.org \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).