From: Grant Likely <grant.likely@secretlab.ca>
To: Sachin Kamat <sachin.kamat@linaro.org>, linux-kernel@vger.kernel.org
Cc: linus.walleij@stericsson.com, ben@simtec.co.uk,
sachin.kamat@linaro.org, patches@linaro.org
Subject: Re: [PATCH] ARM: EXYNOS: Fix compiler warning in gpio-samsung.c file
Date: Tue, 03 Apr 2012 08:59:06 -0600 [thread overview]
Message-ID: <20120403145906.224FD3E0415@localhost> (raw)
In-Reply-To: <1333442575-8777-1-git-send-email-sachin.kamat@linaro.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2435 bytes --]
On Tue, 3 Apr 2012 14:12:55 +0530, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Fixes the following warning when "SAMSUNG EXYNOS5" is not selected:
>
> warning: ‘exynos5_gpios_1’ defined but not used [-Wunused-variable]
> warning: ‘exynos5_gpios_2’ defined but not used [-Wunused-variable]
> warning: ‘exynos5_gpios_3’ defined but not used [-Wunused-variable]
> warning: ‘exynos5_gpios_4’ defined but not used [-Wunused-variable]
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied, thanks.
g.
> ---
> drivers/gpio/gpio-samsung.c | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index 4627787..19d6fc0 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -2382,8 +2382,8 @@ static struct samsung_gpio_chip exynos4_gpios_3[] = {
> #endif
> };
>
> -static struct samsung_gpio_chip exynos5_gpios_1[] = {
> #ifdef CONFIG_ARCH_EXYNOS5
> +static struct samsung_gpio_chip exynos5_gpios_1[] = {
> {
> .chip = {
> .base = EXYNOS5_GPA0(0),
> @@ -2541,11 +2541,11 @@ static struct samsung_gpio_chip exynos5_gpios_1[] = {
> .to_irq = samsung_gpiolib_to_irq,
> },
> },
> -#endif
> };
> +#endif
>
> -static struct samsung_gpio_chip exynos5_gpios_2[] = {
> #ifdef CONFIG_ARCH_EXYNOS5
> +static struct samsung_gpio_chip exynos5_gpios_2[] = {
> {
> .chip = {
> .base = EXYNOS5_GPE0(0),
> @@ -2602,11 +2602,11 @@ static struct samsung_gpio_chip exynos5_gpios_2[] = {
>
> },
> },
> -#endif
> };
> +#endif
>
> -static struct samsung_gpio_chip exynos5_gpios_3[] = {
> #ifdef CONFIG_ARCH_EXYNOS5
> +static struct samsung_gpio_chip exynos5_gpios_3[] = {
> {
> .chip = {
> .base = EXYNOS5_GPV0(0),
> @@ -2638,11 +2638,11 @@ static struct samsung_gpio_chip exynos5_gpios_3[] = {
> .label = "GPV4",
> },
> },
> -#endif
> };
> +#endif
>
> -static struct samsung_gpio_chip exynos5_gpios_4[] = {
> #ifdef CONFIG_ARCH_EXYNOS5
> +static struct samsung_gpio_chip exynos5_gpios_4[] = {
> {
> .chip = {
> .base = EXYNOS5_GPZ(0),
> @@ -2650,8 +2650,8 @@ static struct samsung_gpio_chip exynos5_gpios_4[] = {
> .label = "GPZ",
> },
> },
> -#endif
> };
> +#endif
>
>
> #if defined(CONFIG_ARCH_EXYNOS) && defined(CONFIG_OF)
> --
> 1.7.4.1
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
prev parent reply other threads:[~2012-04-03 23:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 8:42 [PATCH] ARM: EXYNOS: Fix compiler warning in gpio-samsung.c file Sachin Kamat
2012-04-03 14:59 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120403145906.224FD3E0415@localhost \
--to=grant.likely@secretlab.ca \
--cc=ben@simtec.co.uk \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).