From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: linux-input@vger.kernel.org
Cc: Wanlong Gao <gaowanlong@cn.fujitsu.com>,
Che-Liang Chiou <clchiou@chromium.org>,
David Herrmann <dh.herrmann@googlemail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] Input: serio_raw - ensure we don't block in non-blocking read
Date: Tue, 3 Apr 2012 13:24:33 -0700 [thread overview]
Message-ID: <20120403202432.GA18564@core.coreip.homeip.net> (raw)
Avoid calling wait_event_interruptible() if client requested non-blocking
read, since it is not guaranteed that another thread will not consume
event after we checked if serio_raw->head != serio_raw->tail.
Also ensure we do not return 0 but keep waiting instead in blocking case,
when another thread steals "our" byte.
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---
drivers/input/serio/serio_raw.c | 43 ++++++++++++++++++++++----------------
1 files changed, 25 insertions(+), 18 deletions(-)
diff --git a/drivers/input/serio/serio_raw.c b/drivers/input/serio/serio_raw.c
index 4494233..094d6fb 100644
--- a/drivers/input/serio/serio_raw.c
+++ b/drivers/input/serio/serio_raw.c
@@ -165,31 +165,38 @@ static ssize_t serio_raw_read(struct file *file, char __user *buffer,
struct serio_raw *serio_raw = client->serio_raw;
char uninitialized_var(c);
ssize_t read = 0;
- int retval;
+ int error = 0;
- if (serio_raw->dead)
- return -ENODEV;
+ do {
+ if (serio_raw->dead)
+ return -ENODEV;
- if (serio_raw->head == serio_raw->tail && (file->f_flags & O_NONBLOCK))
- return -EAGAIN;
+ if (serio_raw->head == serio_raw->tail &&
+ (file->f_flags & O_NONBLOCK))
+ return -EAGAIN;
- retval = wait_event_interruptible(serio_raw->wait,
- serio_raw->head != serio_raw->tail || serio_raw->dead);
- if (retval)
- return retval;
+ if (count == 0)
+ break;
- if (serio_raw->dead)
- return -ENODEV;
+ while (read < count && serio_raw_fetch_byte(serio_raw, &c)) {
+ if (put_user(c, buffer++)) {
+ error = -EFAULT;
+ goto out;
+ }
+ read++;
+ }
- while (read < count && serio_raw_fetch_byte(serio_raw, &c)) {
- if (put_user(c, buffer++)) {
- retval = -EFAULT;
+ if (read)
break;
- }
- read++;
- }
- return read ?: retval;
+ if (!(file->f_flags & O_NONBLOCK))
+ error = wait_event_interruptible(serio_raw->wait,
+ serio_raw->head != serio_raw->tail ||
+ serio_raw->dead);
+ } while (!error);
+
+out:
+ return read ?: error;
}
static ssize_t serio_raw_write(struct file *file, const char __user *buffer,
--
1.7.7.6
--
Dmitry
next reply other threads:[~2012-04-03 20:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 20:24 Dmitry Torokhov [this message]
2012-04-11 7:23 ` [PATCH] Input: serio_raw - ensure we don't block in non-blocking read Dmitry Torokhov
2012-04-13 16:50 ` David Herrmann
2012-04-17 8:56 ` Che-liang Chiou
2012-04-17 9:14 ` Che-liang Chiou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120403202432.GA18564@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=clchiou@chromium.org \
--cc=dh.herrmann@googlemail.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).