From: Stephen Hemminger <shemminger@vyatta.com>
To: Chris Metcalf <cmetcalf@tilera.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] marvell sky2 driver: fix so it works without unaligned accesses
Date: Wed, 4 Apr 2012 09:04:52 -0700 [thread overview]
Message-ID: <20120404090452.7f13a652@s6510.linuxnetplumber.net> (raw)
In-Reply-To: <201204041419.q34EJ49H025297@farm-0012.internal.tilera.com>
On Wed, 4 Apr 2012 10:13:32 -0400
Chris Metcalf <cmetcalf@tilera.com> wrote:
> The driver uses a receive_new() routine that ends up requiring unaligned
> accesses in IP header processing. If the architecture doesn't support
> efficient unaligned accesses, and SKY2_HW_RAM_BUFFER is set,
> just copy all ingress packets to the bounce buffers instead.
> Thanks to Eric Dumazet for pointing out the SKY2_HW_RAM_BUFFER issue.
>
> This allows the driver to be used on the Tilera TILEmpower-Gx, since
> the tile architecture doesn't currently handle kernel unaligned accesses,
> just userspace.
>
> Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
Still kind of ugly, I will cleanup
next prev parent reply other threads:[~2012-04-04 16:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 15:13 [PATCH] marvell sky2 driver: fix so it works without unaligned accesses Chris Metcalf
2012-04-03 16:17 ` Stephen Hemminger
2012-04-03 16:18 ` Eric Dumazet
2012-04-03 21:46 ` David Miller
2012-04-04 14:13 ` [PATCH v2] " Chris Metcalf
2012-04-04 16:04 ` Stephen Hemminger [this message]
2012-04-04 18:42 ` Stephen Hemminger
2012-04-04 21:52 ` Chris Metcalf
2012-04-04 22:10 ` [PATCH v3] sky2: copy received packets on inefficient unaligned architecture Stephen Hemminger
2012-04-04 22:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120404090452.7f13a652@s6510.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).