From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] Fix perf build failure on glibc trunk
Date: Wed, 4 Apr 2012 11:55:10 +0200 [thread overview]
Message-ID: <20120404095510.GB294@x4> (raw)
In-Reply-To: <20120404094604.GA5930@gmail.com>
On 2012.04.04 at 11:46 +0200, Ingo Molnar wrote:
>
> * Markus Trippelsdorf <markus@trippelsdorf.de> wrote:
>
> > On a system running glibc trunk perf doesn't build:
> >
> > CC builtin-sched.o
> > builtin-sched.c: In function ‘get_cpu_usage_nsec_parent’:
> > builtin-sched.c:399:16: error: storage size of ‘ru’ isn’t known
> > builtin-sched.c:403:2: error: implicit declaration of function ‘getrusage’ [-Werror=implicit-function-declaration]
> > builtin-sched.c:403:2: error: nested extern declaration of ‘getrusage’ [-Werror=nested-externs]
> > builtin-sched.c:403:18: error: ‘RUSAGE_SELF’ undeclared (first use in this function)
> > builtin-sched.c:403:18: note: each undeclared identifier is reported only once for each function it appears in
> > builtin-sched.c:399:16: error: unused variable ‘ru’ [-Werror=unused-variable]
> > cc1: all warnings being treated as errors
> >
> > Fix it by including sys/resource.h.
> > ---
> > tools/perf/builtin-sched.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> Can I add:
>
> Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Yes sure. Sorry.
--
Markus
next prev parent reply other threads:[~2012-04-04 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 8:45 [PATCH] Fix perf build failure on glibc trunk Markus Trippelsdorf
2012-04-04 9:46 ` Ingo Molnar
2012-04-04 9:55 ` Markus Trippelsdorf [this message]
2012-04-04 10:08 ` [tip:perf/urgent] perf tools: Fix getrusage() related " tip-bot for Markus Trippelsdorf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120404095510.GB294@x4 \
--to=markus@trippelsdorf.de \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).