From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752510Ab2DMMJr (ORCPT <rfc822;w@1wt.eu>);
	Fri, 13 Apr 2012 08:09:47 -0400
Received: from 28dayslater.mr.itd.umich.edu ([141.211.12.118]:37039 "EHLO
	28dayslater.mr.itd.umich.edu" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1753316Ab2DMMJY (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 13 Apr 2012 08:09:24 -0400
Date: Fri, 13 Apr 2012 08:02:32 -0400
From: Jim Rees <rees@umich.edu>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
        linux-kernel@vger.kernel.org, pstaubach@exagrid.com, miklos@szeredi.hu,
        viro@ZenIV.linux.org.uk, hch@infradead.org,
        michael.brantley@deshaw.com
Subject: Re: [PATCH RFC] vfs: make fstatat retry on ESTALE errors from
 getattr call
Message-ID: <20120413120232.GA27179@umich.edu>
References: <1334316311-22331-1-git-send-email-jlayton@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1334316311-22331-1-git-send-email-jlayton@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Jeff Layton wrote:

  +retry:
   	error = user_path_at(dfd, filename, lookup_flags, &path);
   	if (error)
   		goto out;
   
   	error = vfs_getattr(path.mnt, path.dentry, stat);
  +	should_retry = error == -ESTALE ? retry_estale(path.dentry) : false;
   	path_put(&path);
  +	if (should_retry) {
  +		lookup_flags |= LOOKUP_REVAL;
  +		goto retry;
  +	}
   out:
   	return error;
   }

This is starting to look like FORTRAN.  Maybe turn this into a "do while"?
Then you could make the "goto out" into a break and get rid of them both.