From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Len Brown <lenb@kernel.org>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Zhang Rui <rui.zhang@intel.com>,
Huang Ying <huang.ying.caritas@gmail.com>,
Aaron Lu <aaron.lu@amd.com>
Subject: Re: [PATCH 1/6] ACPI: D3cold state is always valid
Date: Wed, 18 Apr 2012 11:09:29 +0200 [thread overview]
Message-ID: <201204181109.29355.rjw@sisk.pl> (raw)
In-Reply-To: <1334716348.11188.148.camel@minggr>
On Wednesday, April 18, 2012, Lin Ming wrote:
> On Wed, 2012-04-18 at 10:15 +0800, Lin Ming wrote:
> > (fix Len's address)
> >
> > On Tue, 2012-04-17 at 22:29 +0200, Rafael J. Wysocki wrote:
> > > On Tuesday, April 17, 2012, Lin Ming wrote:
> > > > ACPI_STATE_D3 actually means ACPI D3hot which is not always valid.
> > > > Instead, ACPI D3cold is always valid.
> > > >
> > > > Signed-off-by: Lin Ming <ming.m.lin@intel.com>
> > >
> > > Can you just introduce ACPI_STATE_D3_HOT and redefine D3_COLD so that
> > > it's the same as D3, as I said?
> >
> > Do you mean below?
>
> Or you mean below?
This one, with a minor nit.
> diff --git a/include/acpi/actypes.h b/include/acpi/actypes.h
> index eba6604..5852b8a 100644
> --- a/include/acpi/actypes.h
> +++ b/include/acpi/actypes.h
> @@ -499,8 +499,9 @@ typedef u64 acpi_integer;
> #define ACPI_STATE_D0 (u8) 0
> #define ACPI_STATE_D1 (u8) 1
> #define ACPI_STATE_D2 (u8) 2
> -#define ACPI_STATE_D3 (u8) 3
> -#define ACPI_STATE_D3_COLD (u8) 4
> +#define ACPI_STATE_D3_HOT (u8) 3
> +#define ACPI_STATE_D3 (u8) 4
> +#define ACPI_STATE_D3_COLD ACPI_STATE_D3
> #define ACPI_D_STATES_MAX ACPI_STATE_D3_COLD
I'd say
#define ACPI_D_STATES_MAX ACPI_STATE_D3
> #define ACPI_D_STATE_COUNT 5
Thanks,
Rafael
next prev parent reply other threads:[~2012-04-18 9:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 5:47 [PATCH 0/6]: ACPI D3 state cleanup Lin Ming
2012-04-17 5:47 ` [PATCH 1/6] ACPI: D3cold state is always valid Lin Ming
2012-04-17 6:03 ` huang ying
2012-04-18 21:13 ` Rafael J. Wysocki
2012-04-19 1:35 ` huang ying
2012-04-19 11:51 ` Rafael J. Wysocki
2012-04-19 15:23 ` Lin Ming
2012-04-19 20:39 ` Rafael J. Wysocki
2012-04-17 20:29 ` Rafael J. Wysocki
2012-04-18 2:15 ` Lin Ming
2012-04-18 2:32 ` Lin Ming
2012-04-18 9:09 ` Rafael J. Wysocki [this message]
2012-04-17 5:47 ` [PATCH 2/6] ACPI: Set D3cold state as default device sleep state Lin Ming
2012-04-17 5:47 ` [PATCH 3/6] ACPI: Set D3cold state as default inferred state Lin Ming
2012-04-17 5:47 ` [PATCH 4/6] ACPI: Fix power resource's device power state when it's off Lin Ming
2012-04-17 5:47 ` [PATCH 5/6] PCI/ACPI: Map PCI D3cold state to ACPI D3cold state Lin Ming
2012-04-17 5:47 ` [PATCH 6/6] ACPI: Rename ACPI_STATE_D3 to ACPI_STATE_D3_HOT Lin Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204181109.29355.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=aaron.lu@amd.com \
--cc=huang.ying.caritas@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).