linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Jim Kukunas <james.t.kukunas@linux.intel.com>
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org
Subject: Re: arch/86: AVX RAID5 xor checksumming v1
Date: Thu, 19 Apr 2012 10:02:28 +1000	[thread overview]
Message-ID: <20120419100228.05112e58@notabene.brown> (raw)
In-Reply-To: <1334789928-7238-1-git-send-email-james.t.kukunas@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 743 bytes --]

On Wed, 18 Apr 2012 15:58:47 -0700 Jim Kukunas
<james.t.kukunas@linux.intel.com> wrote:

> Hi Folks,
> 
> The following patch adds an AVX implementation of the RAID5 xor checksumming
> functions.
> 
> This version differs from version 0, in that it:
> 	0) checks whether assembler supports AVX
> 	1) replaces __attribute__(aligned(32)) with __aligned(32)
> 	2) adds do/while(0); to macro blocks
> 
> Based on xor_speed, the AVX implementation appears to be ~32% faster than the
> SSE implementation on my i7 2600:
> 
>         generic_sse: 15088.000 MB/sec
> 	avx: 19936.000 MB/sec
> 

Applied, thanks.
(though I remove the blank line at the end of the new file - the voices made
me do it, I had no choice)

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

      parent reply	other threads:[~2012-04-19  0:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-18 22:58 arch/86: AVX RAID5 xor checksumming v1 Jim Kukunas
2012-04-18 22:58 ` [PATCH] raid5: add AVX optimized RAID5 checksumming Jim Kukunas
2012-04-19  0:02 ` NeilBrown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120419100228.05112e58@notabene.brown \
    --to=neilb@suse.de \
    --cc=hpa@zytor.com \
    --cc=james.t.kukunas@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).