From: Luis Henriques <luis.henriques@canonical.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Jarod Wilson <jarod@redhat.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/1] [media] ite-cir: postpone ISR registration
Date: Thu, 19 Apr 2012 16:08:13 +0100 [thread overview]
Message-ID: <20120419150813.GA22948@zeus> (raw)
In-Reply-To: <1334782447-8742-1-git-send-email-luis.henriques@canonical.com>
On Wed, Apr 18, 2012 at 09:54:07PM +0100, Luis Henriques wrote:
> An early registration of an ISR was causing a crash to several users (for
> example here: http://bugs.launchpad.net/bugs/972723 The reason was that
> IRQs were being triggered before the driver initialisation was completed.
>
> This patch fixes this by moving the invocation to request_irq() to a later
> stage on the driver probe function.
>
> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
> ---
> drivers/media/rc/ite-cir.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/rc/ite-cir.c b/drivers/media/rc/ite-cir.c
> index 682009d..98d8ccf 100644
> --- a/drivers/media/rc/ite-cir.c
> +++ b/drivers/media/rc/ite-cir.c
> @@ -1521,10 +1521,6 @@ static int ite_probe(struct pnp_dev *pdev, const struct pnp_device_id
> dev_desc->io_region_size, ITE_DRIVER_NAME))
> goto failure;
>
> - if (request_irq(itdev->cir_irq, ite_cir_isr, IRQF_SHARED,
> - ITE_DRIVER_NAME, (void *)itdev))
> - goto failure;
> -
> /* set driver data into the pnp device */
> pnp_set_drvdata(pdev, itdev);
> itdev->pdev = pdev;
> @@ -1600,6 +1596,10 @@ static int ite_probe(struct pnp_dev *pdev, const struct pnp_device_id
> rdev->driver_name = ITE_DRIVER_NAME;
> rdev->map_name = RC_MAP_RC6_MCE;
>
> + if (request_irq(itdev->cir_irq, ite_cir_isr, IRQF_SHARED,
> + ITE_DRIVER_NAME, (void *)itdev))
> + goto failure;
> +
> ret = rc_register_device(rdev);
> if (ret)
> goto failure;
> --
> 1.7.9.5
I completely forgot to add:
Cc: <stable@vger.kernel.org>
to my email.
Cheers,
--
Luis
next prev parent reply other threads:[~2012-04-19 15:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 20:54 [PATCH 1/1] [media] ite-cir: postpone ISR registration Luis Henriques
2012-04-19 15:08 ` Luis Henriques [this message]
2012-04-19 20:44 ` Jarod Wilson
2012-04-19 21:32 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120419150813.GA22948@zeus \
--to=luis.henriques@canonical.com \
--cc=jarod@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).