From: Nick Bowler <nbowler@elliptictech.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Martin Peres <martin.peres@labri.fr>,
Ben Skeggs <bskeggs@redhat.com>,
dri-devel@lists.freedesktop.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 3.4-rc4
Date: Tue, 24 Apr 2012 21:35:37 -0400 [thread overview]
Message-ID: <20120425013537.GA11959@elliptictech.com> (raw)
In-Reply-To: <20120424010345.GA30674@elliptictech.com>
On 2012-04-23 21:03 -0400, Nick Bowler wrote:
> On 2012-04-22 22:45 -0400, Konrad Rzeszutek Wilk wrote:
> > On Sun, Apr 22, 2012 at 08:05:54PM -0400, Nick Bowler wrote:
> > > Following up on the above, the commit which introduces the panics during
> > > boot is this one:
> > >
> > > commit 8e7e70522d760c4ccd4cd370ebfa0ba69e006c6e
> > > Author: Jerome Glisse <jglisse@redhat.com>
> > > Date: Wed Nov 9 17:15:26 2011 -0500
> > >
> > > drm/ttm: isolate dma data from ttm_tt V4
[...]
> > dea7e0a ttm: fix agp since ttm tt rework
> >
> > fixed that.
>
> Yes, I just tested this commit and the one immediately before it. The
> one before crashes in the usual way, and dea7e0a boots (with the VGA
> output black as in the original report). So this fixed the crash.
OK, here's what I did:
- Since dea7e0a is the first commit that both (a) boots and (b) has
broken VGA, I checked it out on a new branch:
git checkout -b crazy dea7e0a
- Next, I reverted *all* (well, I missed one by accident) the remaining
nouveau-specific commits between 3230cfc34 ("drm/nouveau: enable the
ttm dma pool when swiotlb is active V3") (i.e., the last commit that
(a) boots and (b) has non-broken VGA) and dea7e0a:
git revert --no-edit 0c101461e267..f7b24c42da1a
- Amazingly, the resulting kernel booted and had working VGA, so I did
a "backwards" bisect on this branch of reverts. In a strange twist
of fate, this actually managed to produce bootable kernels the entire
time. The bisection pinpointed the following commit as the culprit:
commit a0b25635515ef5049f93b032a1e37f18b16e0f6f
Author: Ben Skeggs <bskeggs@redhat.com>
Date: Mon Nov 21 16:41:48 2011 +1000
drm/nouveau/gpio: reimplement as nouveau_gpio.c, fixing a number of issues
- moves out of nouveau_bios.c and demagics the logical state definitions
- simplifies chipset-specific driver interface
- makes most of gpio irq handling common, will use for nv4x hpd later
- api extended to allow both direct gpio access, and access using the
logical function states
- api extended to allow for future use of gpio extender chips
- pre-nv50 was handled very badly, the main issue being that all GPIOs
were being treated as output-only.
- fixes nvd0 so gpio changes actually stick, magic reg needs bashing
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Unfortunately, there are a number of seemingly non-trivial conflicts
trying to revert just this one gigantic commit. So to avoid any
conflicts, I reverted all of the following (in this order) on top of
3.3.3 (there are even more conflicts trying to revert on top of Linus'
master):
7df898b1a70b ("drm/nouveau/disp: check that panel power gpio is enabled at init time")
52c4d767437b ("drm/nouveau: move hpd enable/disable to common code")
47e5d5cb83d4 ("drm/nv40/disp: implement support for hotplug irq")
a0b25635515e ("drm/nouveau/gpio: reimplement as nouveau_gpio.c, fixing a number of issues")
and my VGA is working again!
Cheers,
--
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)
next prev parent reply other threads:[~2012-04-25 1:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-21 22:43 Linux 3.4-rc4 Linus Torvalds
2012-04-22 4:07 ` Nick Bowler
2012-04-22 4:51 ` Linus Torvalds
2012-04-22 7:26 ` Dave Airlie
2012-04-22 16:42 ` Nick Bowler
2012-04-23 3:16 ` Ben Skeggs
2012-04-22 16:40 ` Nick Bowler
2012-04-22 18:20 ` Geert Uytterhoeven
2012-04-23 0:05 ` Nick Bowler
2012-04-23 2:45 ` Konrad Rzeszutek Wilk
2012-04-24 1:03 ` Nick Bowler
2012-04-24 15:11 ` Konrad Rzeszutek Wilk
2012-04-25 1:35 ` Nick Bowler [this message]
2012-04-25 2:56 ` Ben Skeggs
2012-04-27 5:20 ` Ben Skeggs
2012-04-28 0:39 ` Nick Bowler
2012-04-28 6:19 ` Alex Deucher
2012-04-28 15:33 ` Nick Bowler
2012-04-29 22:37 ` Dmitry Torokhov
2012-04-30 9:07 ` Maarten Maathuis
2012-04-30 11:01 ` Luca Tettamanti
2012-05-02 7:54 ` Jean Delvare
2012-05-02 11:31 ` Ben Skeggs
2012-05-04 5:08 ` Ben Skeggs
2012-05-04 14:12 ` Jean Delvare
2012-05-01 13:23 ` Nick Bowler
2012-05-01 15:09 ` Alan Cox
2012-05-01 15:31 ` Nick Bowler
2012-05-01 15:45 ` Alan Cox
2012-05-02 1:20 ` Nick Bowler
2012-05-04 9:20 ` Dave Airlie
2012-05-05 15:39 ` Nick Bowler
2012-04-22 8:38 ` Bjarke Istrup Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120425013537.GA11959@elliptictech.com \
--to=nbowler@elliptictech.com \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.peres@labri.fr \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).