From: Tejun Heo <tj@kernel.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Peter Zijlstra <peterz@infradead.org>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: Lockdep false positive in sysfs
Date: Fri, 27 Apr 2012 14:16:25 -0700 [thread overview]
Message-ID: <20120427211625.GP26595@google.com> (raw)
In-Reply-To: <878vhg3mrh.fsf@xmission.com>
On Fri, Apr 27, 2012 at 02:09:22PM -0700, Eric W. Biederman wrote:
> I don't mind the attitude we are clever careful programmers we can
> handle the complexity and we can get away without the tool help us, but
> I would much rather see the attitude that we are clever careful
> programmers and we can figure out how to make the tool help us instead
> of just ignoring it.
I'm okay with using static array of keys so that each level maps to
separate key or just calling it a special case and ignoring it, but I
think it's quite silly to use an async mechanism just to avoid lockdep
warning. Things like that tend to make things obscure as people
generally don't expect lockdep annotation to dictate overall
behaviors. It is an annotation problem. Let's keep it that way.
Thanks.
--
tejun
next prev parent reply other threads:[~2012-04-27 21:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 18:58 Lockdep false positive in sysfs Alan Stern
2012-04-25 21:59 ` Tejun Heo
2012-04-26 8:16 ` Eric W. Biederman
2012-04-26 18:14 ` Alan Stern
2012-04-26 22:17 ` Tejun Heo
2012-04-27 15:57 ` Alan Stern
2012-04-27 16:09 ` Tejun Heo
2012-05-03 21:30 ` Alan Stern
2012-05-04 16:52 ` Tejun Heo
2012-05-04 19:08 ` Alan Stern
2012-05-07 19:46 ` Tejun Heo
2012-05-07 21:51 ` Alan Stern
2012-05-07 21:55 ` Tejun Heo
2012-05-08 18:53 ` Alan Stern
2012-05-09 17:41 ` Tejun Heo
2012-05-09 17:47 ` Alan Stern
2012-05-09 17:48 ` Tejun Heo
2012-04-27 16:27 ` Eric W. Biederman
2012-04-27 18:27 ` Alan Stern
2012-04-27 20:17 ` Tejun Heo
2012-04-27 21:09 ` Eric W. Biederman
2012-04-27 21:16 ` Tejun Heo [this message]
2012-04-29 2:00 ` Alan Stern
2012-04-29 2:35 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120427211625.GP26595@google.com \
--to=tj@kernel.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).