* [PATCH] video: fb_defio.c: local functions should not be exposed globally
@ 2012-05-03 0:23 H Hartley Sweeten
2012-05-10 0:11 ` Florian Tobias Schandinat
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2012-05-03 0:23 UTC (permalink / raw)
To: Linux Kernel; +Cc: linux-fbdev, jayalk, FlorianSchandinat
Functions not referenced outside of a source file should be marked
static to prevent them from being exposed globally.
Quiets the sparse warning:
warning: symbol 'fb_deferred_io_page' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Jaya Kumar <jayalk@intworks.biz>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
---
diff --git a/drivers/video/fb_defio.c b/drivers/video/fb_defio.c
index 070f26f..1ddeb11 100644
--- a/drivers/video/fb_defio.c
+++ b/drivers/video/fb_defio.c
@@ -23,7 +23,7 @@
#include <linux/rmap.h>
#include <linux/pagemap.h>
-struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs)
+static struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs)
{
void *screen_base = (void __force *) info->screen_base;
struct page *page;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fb_defio.c: local functions should not be exposed globally
2012-05-03 0:23 [PATCH] video: fb_defio.c: local functions should not be exposed globally H Hartley Sweeten
@ 2012-05-10 0:11 ` Florian Tobias Schandinat
0 siblings, 0 replies; 2+ messages in thread
From: Florian Tobias Schandinat @ 2012-05-10 0:11 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, linux-fbdev
On 05/03/2012 12:23 AM, H Hartley Sweeten wrote:
> Functions not referenced outside of a source file should be marked
> static to prevent them from being exposed globally.
>
> Quiets the sparse warning:
>
> warning: symbol 'fb_deferred_io_page' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Jaya Kumar <jayalk@intworks.biz>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Applied.
Thanks,
Florian Tobias Schandinat
>
> ---
>
> diff --git a/drivers/video/fb_defio.c b/drivers/video/fb_defio.c
> index 070f26f..1ddeb11 100644
> --- a/drivers/video/fb_defio.c
> +++ b/drivers/video/fb_defio.c
> @@ -23,7 +23,7 @@
> #include <linux/rmap.h>
> #include <linux/pagemap.h>
>
> -struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs)
> +static struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs)
> {
> void *screen_base = (void __force *) info->screen_base;
> struct page *page;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-10 0:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-03 0:23 [PATCH] video: fb_defio.c: local functions should not be exposed globally H Hartley Sweeten
2012-05-10 0:11 ` Florian Tobias Schandinat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).