From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754838Ab2EBV6l (ORCPT ); Wed, 2 May 2012 17:58:41 -0400 Received: from fieldses.org ([174.143.236.118]:37985 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754019Ab2EBV6k (ORCPT ); Wed, 2 May 2012 17:58:40 -0400 Date: Wed, 2 May 2012 17:58:37 -0400 From: "J. Bruce Fields" To: Stanislav Kinsbursky Cc: Trond.Myklebust@netapp.com, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, devel@openvz.org Subject: Re: [PATCH v3 0/2] SUNRPC: separate per-net data creation from service Message-ID: <20120502215837.GA12089@fieldses.org> References: <20120502120536.8794.22210.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120502120536.8794.22210.stgit@localhost.localdomain> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks, applying. --b. On Wed, May 02, 2012 at 04:08:29PM +0400, Stanislav Kinsbursky wrote: > creation > > v3: "SUNRPC: new svc_bind() routine introduced" patch was squashed with the > "SUNRPC: check rpcbind clients usage counter before decrement" patch. > > v2: Increase per-net usage counted in lockd_up_net(). > > This is a cleanup patch set. > It will be followed my LockD start/stop cleanup patch set and NFS callback > service containerization patch set (yes, I forgot to implement it). > > Today per-net data is created with service, and then is service is starting in > other network namespace. And thus it's destroyed with service too. Moreover, > network context for destroying of per-net data is taken from current process. > This is correct, but code looks ugly. > This patch set separates per-net data allocation from service allocation and > destruction. > IOW, per-net data have to be destroyed by service users - not service itself. > > BTW, NFSd code become uglier with this patch set. Sorry. > But I assume, that these new ugly parts will be replaced later by NFSd service > containerization code. > > The following series implements... > > --- > > Stanislav Kinsbursky (2): > SUNRPC: new svc_bind() routine introduced > SUNRPC: move per-net operations from svc_destroy() > > > fs/lockd/svc.c | 33 +++++++++++++++++++++------------ > fs/nfs/callback.c | 11 +++++++++++ > fs/nfsd/nfsctl.c | 4 ++++ > fs/nfsd/nfssvc.c | 16 ++++++++++++++++ > include/linux/sunrpc/svc.h | 1 + > net/sunrpc/rpcb_clnt.c | 12 +++++++----- > net/sunrpc/svc.c | 23 ++++++++++------------- > 7 files changed, 70 insertions(+), 30 deletions(-) >