From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org,
Misael Lopez Cruz <misael.lopez@ti.com>,
Benoit Cousson <b-cousson@ti.com>,
devicetree-discuss@lists.ozlabs.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 2/3] MFD: twl6040: Allocate IRQ numbers dynamically
Date: Thu, 3 May 2012 14:20:05 +0100 [thread overview]
Message-ID: <20120503132004.GB14296@sirena.org.uk> (raw)
In-Reply-To: <1336049665-27777-3-git-send-email-peter.ujfalusi@ti.com>
On Thu, May 03, 2012 at 03:54:24PM +0300, Peter Ujfalusi wrote:
> /* In order to operate correctly we need valid interrupt config */
> - if (!client->irq || !pdata->irq_base) {
> + if (!client->irq) {
It looks like you're totally removing the use of irq_base which will
break any boards that didn't convert to DT. The usual idiom is to use
irq_base as the base for the range of requested IRQs if it's supplied,
otherwise set it to -1 to allow dynamic allocation. This should keep
existing users working without disruption.
next prev parent reply other threads:[~2012-05-03 13:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 12:54 [PATCH 0/3] MFD: twl6040: Device tree support Peter Ujfalusi
2012-05-03 12:54 ` [PATCH 1/3] MFD: twl6040: Code cleanup in interrupt initialization part Peter Ujfalusi
2012-05-03 12:54 ` [PATCH 2/3] MFD: twl6040: Allocate IRQ numbers dynamically Peter Ujfalusi
2012-05-03 13:20 ` Mark Brown [this message]
2012-05-03 13:28 ` Peter Ujfalusi
2012-05-03 14:52 ` Mark Brown
2012-05-03 15:13 ` Peter Ujfalusi
2012-05-03 15:26 ` Mark Brown
2012-05-04 8:38 ` Peter Ujfalusi
2012-05-04 9:08 ` Mark Brown
2012-05-04 10:37 ` Peter Ujfalusi
2012-05-04 11:22 ` Mark Brown
2012-05-04 11:55 ` Peter Ujfalusi
2012-05-04 12:17 ` Mark Brown
2012-05-04 12:33 ` Peter Ujfalusi
2012-05-04 12:47 ` Mark Brown
2012-05-07 6:49 ` Peter Ujfalusi
2012-05-07 9:49 ` Mark Brown
2012-05-03 12:54 ` [PATCH 3/3] MFD: twl6040: Support for DT Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120503132004.GB14296@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).