Re: [PATCH] fs: Move bh_cachep to the __read_mostly section

From: Vlad Zolotarov <vlad@scalemp.com>
To: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>,
	alan@lxorguk.ukuu.org.uk,
	"Shai Fultheim (Shai@ScaleMP.com)" <Shai@scalemp.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] fs: Move bh_cachep to the __read_mostly section
Date: Thu, 3 May 2012 14:26:26 +0300	[thread overview]
Message-ID: <201205031426.27432.vlad@scalemp.com> (raw)
In-Reply-To: <201204241422.23065.vlad@scalemp.com>

On Tuesday, April 24, 2012 02:22:22 pm Vlad Zolotarov wrote:
> From: Shai Fultheim <shai@scalemp.com>
> 
> bh_cachep is only written to once on initialization, so move it to the
> __read_mostly section.
> 
> Signed-off-by: Shai Fultheim <shai@scalemp.com>
> Signed-off-by: Vlad Zolotarov <vlad@scalemp.com>
> ---
>  fs/buffer.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 36d6665..a1d82fb 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -3151,7 +3151,7 @@ SYSCALL_DEFINE2(bdflush, int, func, long, data)
>  /*
>   * Buffer-head allocation
>   */
> -static struct kmem_cache *bh_cachep;
> +static struct kmem_cache *bh_cachep __read_mostly;
> 
>  /*
>   * Once the number of bh's in the machine exceeds this level, we start

Thomas, Ingo, Peter, Alan, do u want me to respin this patch? 
(Alan, this one is not x86 ;))

Could u, pls., advice what should be done for it to be applied?

thanks,
vlad