From: Dan Carpenter <dan.carpenter@oracle.com>
To: Johannes Thumshirn <morbidrsa@googlemail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, stefanha@gmail.com,
andor.daam@googlemail.com, grabner@icg.tugraz.at,
jj@chaosbits.net, thomas@m3y3r.de
Subject: Re: [PATCH 1/8] drivers/staging/line6/control.c: Change strict_strtoul to kstrtoul
Date: Sun, 6 May 2012 09:34:50 +0300 [thread overview]
Message-ID: <20120506063450.GH22134@mwanda> (raw)
In-Reply-To: <1336228312-5379-2-git-send-email-morbidrsa@googlemail.com>
On Sat, May 05, 2012 at 04:31:45PM +0200, Johannes Thumshirn wrote:
> Changed strict_strtoul() call to kstrtoul to make checkpatch.pl happy
>
This would probably be better as kstrtou8(). You'd have to change
the type of value, and the function parameters which take value as
well. Also you would have to change the name of pod_set_param_int()
because it says "int".
regards,
dan carpenter
next prev parent reply other threads:[~2012-05-06 6:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-05 14:31 [PATCH 0/8] drivers/staging/line6/ chechpatch.pl cleanups Johannes Thumshirn
2012-05-05 14:31 ` [PATCH 1/8] drivers/staging/line6/control.c: Change strict_strtoul to kstrtoul Johannes Thumshirn
2012-05-06 6:34 ` Dan Carpenter [this message]
2012-05-06 8:27 ` Johannes Thumshirn
2012-05-06 11:12 ` Dan Carpenter
2012-05-05 14:31 ` [PATCH 2/8] drivers/staging/line6/pod.c: " Johannes Thumshirn
2012-05-06 6:38 ` Dan Carpenter
2012-05-05 14:31 ` [PATCH 3/8] drivers/staging/line6/variax.c: " Johannes Thumshirn
2012-05-06 6:45 ` Dan Carpenter
2012-05-05 14:31 ` [PATCH 4/8] drivers/staging/line6/config.h: changed printk(KERN_INFO, ... to pr_info( Johannes Thumshirn
2012-05-06 6:40 ` Dan Carpenter
2012-05-05 14:31 ` [PATCH 5/8] drivers/staging/line6/driver.h: Changed printk(KERN_ERR, .. to pr_err Changed printk(KERN_ERR, ...) call to pr_err() call in MISSING_CASE macro Johannes Thumshirn
2012-05-06 6:42 ` Dan Carpenter
2012-05-05 14:31 ` [PATCH 6/8] drivers/staging/line6/midibuf.c changed printk(KERN_DEBUG, ... to pr_debug( Johannes Thumshirn
2012-05-05 14:31 ` [PATCH 7/8] drivers/staging/line6/midi.c: Added space between switch and open parenthesis Johannes Thumshirn
2012-05-05 14:31 ` [PATCH 8/8] drivers/staging/line6/pcm.c: Removed trailing whitespace Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120506063450.GH22134@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andor.daam@googlemail.com \
--cc=devel@driverdev.osuosl.org \
--cc=grabner@icg.tugraz.at \
--cc=gregkh@linuxfoundation.org \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=morbidrsa@googlemail.com \
--cc=stefanha@gmail.com \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).