From: Grant Likely <grant.likely@secretlab.ca>
To: David Daney <ddaney.cavm@gmail.com>,
linux-mips@linux-mips.org, ralf@linux-mips.org,
devicetree-discuss@lists.ozlabs.org,
Rob Herring <rob.herring@calxeda.com>
Cc: linux-kernel@vger.kernel.org,
David Daney <david.daney@cavium.com>,
"Jean Delvare (PC drivers, core)" <khali@linux-fr.org>,
"Ben Dooks (embedded platforms)" <ben-linux@fluff.org>,
"Wolfram Sang (embedded platforms)" <w.sang@pengutronix.de>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2 1/5] i2c: Convert i2c-octeon.c to use device tree.
Date: Sat, 19 May 2012 00:05:09 -0600 [thread overview]
Message-ID: <20120519060509.DAD0F3E046E@localhost> (raw)
In-Reply-To: <1335489630-27017-2-git-send-email-ddaney.cavm@gmail.com>
On Thu, 26 Apr 2012 18:20:26 -0700, David Daney <ddaney.cavm@gmail.com> wrote:
> From: David Daney <david.daney@cavium.com>
>
> There are three parts to this:
>
> 1) Remove the definitions of OCTEON_IRQ_TWSI and OCTEON_IRQ_TWSI2.
> The interrupts are specified by the device tree and these hard
> coded irq numbers block the used of the irq lines by the irq_domain
> code.
>
> 2) Remove platform device setup code from octeon-platform.c, it is
> now unused.
>
> 3) Convert i2c-octeon.c to use device tree. Part of this includes
> using the devm_* functions instead of the raw counterparts, thus
> simplifying error handling. No functionality is changed.
>
> Signed-off-by: David Daney <david.daney@cavium.com>
> Acked-by: Rob Herring <rob.herring@calxeda.com>
Is the DT binding for this device documented?
Otherwise the code looks good. Please make sure the binding
documentation is in place before merging.
g.
next prev parent reply other threads:[~2012-05-19 6:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 1:20 [PATCH v2 0/5] MIPS: OCTEON: Convert some device to use Device Tree David Daney
2012-04-27 1:20 ` [PATCH v2 1/5] i2c: Convert i2c-octeon.c to use device tree David Daney
2012-05-03 11:26 ` Wolfram Sang
2012-05-19 6:05 ` Grant Likely [this message]
2012-04-27 1:20 ` [PATCH v2 2/5] netdev: mdio-octeon.c: Convert " David Daney
2012-05-19 6:06 ` Grant Likely
2012-04-27 1:20 ` [PATCH v2 3/5] netdev: octeon_mgmt: " David Daney
2012-04-27 1:20 ` [PATCH v2 4/5] staging: octeon_ethernet: " David Daney
2012-05-19 6:07 ` Grant Likely
2012-04-27 1:20 ` [PATCH v2 5/5] MIPS: Octeon: Use device tree to register serial ports David Daney
2012-05-19 6:08 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120519060509.DAD0F3E046E@localhost \
--to=grant.likely@secretlab.ca \
--cc=ben-linux@fluff.org \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rob.herring@calxeda.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).