From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758032Ab2FFSRt (ORCPT ); Wed, 6 Jun 2012 14:17:49 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:38033 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757898Ab2FFSRr (ORCPT ); Wed, 6 Jun 2012 14:17:47 -0400 Date: Wed, 06 Jun 2012 11:17:46 -0700 (PDT) Message-Id: <20120606.111746.576942199242363352.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: cmetcalf@tilera.com, bhutchings@solarflare.com, arnd@arndb.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v9] tilegx network driver: initial support From: David Miller In-Reply-To: <1339006223.26966.36.camel@edumazet-glaptop> References: <201205251853.q4PIrE7T000723@lab-41.internal.tilera.com> <201206042023.q54KNEZp003834@farm-0002.internal.tilera.com> <1339006223.26966.36.camel@edumazet-glaptop> X-Mailer: Mew version 6.5 on Emacs 23.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet Date: Wed, 06 Jun 2012 20:10:23 +0200 > I am pretty sure this performance problem should be solved in net/{core| > ipv4|ipv6} instead > > What TCP performance do you get with TSO/GSO and SG off ? We have other drivers already doing this. I tried a few years ago to make this generic, because NIU could benefit from it as well, but I couldn't figure out a clean enough way to abstract this. Therefore it is absolutely reasonable to continue to let drivers do this locally until we actually have a reasonable solution. The gains are definitely significant for chips that lack real TSO hardware, I absolutely do not require "proof" of this, it is clearly evident to anyone who considers the issue.