On Mon, Jun 18, 2012 at 12:56:40PM +0000, AnilKumar, Chimata wrote: Please fix the word wrapping in your mailer, it looks like it's wrapping at 81 characters or something. > I think it is better to set in regulator it-self instead of these checks + calls, > this adds extra burden. So, regmap pointer set should be added if we are adding > regulator_[is_enabled|get_voltage_sel]_regmap API support to the driver. Yeah, the goal here is to ensure that the common case can be (as far as possible) data rather than code so if there's lots of drivers doing the same thing the core should do it for them.