From: Paul Mundt <lethal@linux-sh.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Barry Song <21cnbao@gmail.com>,
Rohit Vaswani <rvaswani@codeaurora.org>,
Kyungmin Park <kmpark@infradead.org>,
Linus Walleij <linus.walleij@stericsson.com>,
linux-kernel@vger.kernel.org, workgroup.linux@csr.com,
Grant Likely <grant.likely@secretlab.ca>,
Richard Woo <richard.wu@lianlab.org>,
linux-arm-kernel@lists.infradead.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] GPIOLIB: add generic gpio_set_pull API
Date: Wed, 20 Jun 2012 23:31:41 +0900 [thread overview]
Message-ID: <20120620143140.GA7817@linux-sh.org> (raw)
In-Reply-To: <CACRpkdazTKs_sNHVkVAYdz6CK9fwghf2n-Rrs7fi7R1Z=Gt+3w@mail.gmail.com>
On Wed, Jun 20, 2012 at 10:15:01AM +0200, Linus Walleij wrote:
> On Tue, Jun 19, 2012 at 5:25 AM, Barry Song <21cnbao@gmail.com> wrote:
> > but i think at least the macros of GPIO_PULL_NONE, GPIO_PULL_UP and
> > GPIO_PULL_DOWN should be standardized.
>
> You find an attempt at standardization in drivers/pinctrl/pinconf-generic.c
> which is also used by the composite U300+COH901 drivers. Drivers
> can select this support library and use the flags from
> <linux/pinctrl/pinconf-generic.h>
>
What's with PIN_CONFIG_END using such an insane value?
I'm happy to consolidate on the provided definitions and add my own on top
of that, but I'm not going to waste an insane amount of bits that I could
be using for driver-specific data and so on instead to comply with the
PIN_CONFIG_END comment. Is there any valid reason why this would ever
need to exceed 4 bits?
next prev parent reply other threads:[~2012-06-20 14:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 5:19 [PATCH] GPIOLIB: add generic gpio_set_pull API Barry Song
2011-08-08 8:15 ` Paul Mundt
2011-08-08 18:24 ` Grant Likely
2011-08-08 22:57 ` Kyungmin Park
2011-08-09 1:45 ` Rohit Vaswani
2011-08-09 2:51 ` Barry Song
2011-08-09 10:11 ` Linus Walleij
2012-06-19 3:25 ` Barry Song
2012-06-20 8:15 ` Linus Walleij
2012-06-20 10:07 ` Barry Song
2012-06-20 14:31 ` Paul Mundt [this message]
2012-06-21 7:48 ` Linus Walleij
2011-08-09 10:07 ` Linus Walleij
2011-08-09 10:04 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120620143140.GA7817@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=21cnbao@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=grant.likely@secretlab.ca \
--cc=kmpark@infradead.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.wu@lianlab.org \
--cc=rvaswani@codeaurora.org \
--cc=workgroup.linux@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).