From: Andrew Morton <akpm@linux-foundation.org>
To: Octavian Purdila <octavian.purdila@intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, Ram Pai <linuxram@us.ibm.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] resource: make sure requested range intersects root range
Date: Tue, 10 Jul 2012 14:33:48 -0700 [thread overview]
Message-ID: <20120710143348.d977da44.akpm@linux-foundation.org> (raw)
In-Reply-To: <1341057657-7823-1-git-send-email-octavian.purdila@intel.com>
On Sat, 30 Jun 2012 15:00:57 +0300
Octavian Purdila <octavian.purdila@intel.com> wrote:
> When the requested and root ranges do not intersect the logic in
> __reserve_region_with_split will cause an infinite recursion which
> will overflow the stack as seen in the warning bellow.
>
> This particular stack overflow was caused by requesting the
> (100000000-107ffffff) range while the root range was (0-ffffffff). In
> this case __request_resource would return the whole root range as
> conflict range (i.e. 0-ffffffff). Then, the logic in
> __reserve_region_with_split would continue the recursion requesting
> the new range as (conflict->end+1, end) which incidentally in this
> case equals the originally requested range.
>
> This patch aborts looking for a usable range when the requested one is
> completely outside the root range to avoid the infinite recursion, and
> since this indicates a problem in the layers above, it also prints an
> error message indicating the requested and root range in order to make
> the problem more easily traceable.
I think we should also emit a stack trace so the faulty caller can be
pinpointed.
> ...
>
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -789,7 +789,13 @@ void __init reserve_region_with_split(struct resource *root,
> const char *name)
> {
> write_lock(&resource_lock);
> - __reserve_region_with_split(root, start, end, name);
> + if (start > root->end || end < root->start)
> + pr_err("Requested range (0x%llx-0x%llx) not in root range (0x%llx-0x%llx)\n",
> + (unsigned long long)start, (unsigned long long)end,
> + (unsigned long long)root->start,
> + (unsigned long long)root->end);
> + else
> + __reserve_region_with_split(root, start, end, name);
> write_unlock(&resource_lock);
> }
The fancy way of doing that is
if (!WARN(start > root->end || end < root->start),
"Requested range (0x%llx-0x%llx) not in root range (0x%llx-0x%llx)\n",
(unsigned long long)start, (unsigned long long)end,
(unsigned long long)root->start,
(unsigned long long)root->end)
__reserve_region_with_split(root, start, end, name);
but that's quite the eyesore. How about doing it the simple way?
--- a/kernel/resource.c~resource-make-sure-requested-range-intersects-root-range-fix
+++ a/kernel/resource.c
@@ -792,13 +792,15 @@ void __init reserve_region_with_split(st
const char *name)
{
write_lock(&resource_lock);
- if (start > root->end || end < root->start)
+ if (start > root->end || end < root->start) {
pr_err("Requested range (0x%llx-0x%llx) not in root range (0x%llx-0x%llx)\n",
(unsigned long long)start, (unsigned long long)end,
(unsigned long long)root->start,
(unsigned long long)root->end);
- else
+ dump_stack();
+ } else {
__reserve_region_with_split(root, start, end, name);
+ }
write_unlock(&resource_lock);
}
_
next prev parent reply other threads:[~2012-07-10 21:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-30 12:00 [PATCH] resource: make sure requested range intersects root range Octavian Purdila
2012-07-10 21:33 ` Andrew Morton [this message]
2012-07-11 1:25 ` Joe Perches
2012-07-11 2:09 ` Ram Pai
2012-07-11 11:06 ` Purdila, Octavian
2012-07-11 14:54 ` Ram Pai
2012-07-11 15:26 ` Purdila, Octavian
2012-07-12 2:02 ` Ram Pai
2012-07-12 8:56 ` Ram Pai
[not found] ` <CAE1zot+iKwg5uijy7mWbxrQ3KUFYoKXuSYc0OnADmrWu7EtgLw@mail.gmail.com>
[not found] ` <20120712163026.GG2430@ram-ThinkPad-T61>
2012-07-12 16:49 ` Purdila, Octavian
-- strict thread matches above, loose matches on Subject: below --
2012-05-03 8:40 Octavian Purdila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120710143348.d977da44.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=octavian.purdila@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).