From: Borislav Petkov <bp@amd64.org>
To: Alex Shi <alex.shi@intel.com>
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
tj@kernel.org, akpm@linux-foundation.org, sfr@canb.auug.org.au,
linux-kernel@vger.kernel.org, bp@amd64.org,
penguin-kernel@I-love.SAKURA.ne.jp
Subject: Re: [PATCH] x86/tlb: fix allnoconfig building warning
Date: Fri, 20 Jul 2012 10:54:36 +0200 [thread overview]
Message-ID: <20120720085436.GC28767@aftab.osrc.amd.com> (raw)
In-Reply-To: <1342747103-19765-1-git-send-email-alex.shi@intel.com>
On Fri, Jul 20, 2012 at 09:18:23AM +0800, Alex Shi wrote:
> The incompatible parameter of flush_tlb_mm_range cause build warning.
> Fix it by correct parameter.
>
> Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Signed-off-by: Alex Shi <alex.shi@intel.com>
Thanks for this.
Btw, the patch Subject should say:
"[PATCH] x86, tlb: Fix flush_tlb_mm_range signature"
or
"[PATCH] x86, tlb: Fix non-SMP build warning"
or similar. Having "allnoconfig" in the name is a bit misleading as it
is only one of the reasons why we build a !CONFIG_SMP kernel - this can
happen with a randbuild too. And the hunk below touches the "#ifndef
CONFIG_SMP" part of tlbflush.h...
So, long story short, hpa, can pls you correct this when applying?
> ---
> arch/x86/include/asm/tlbflush.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
> index 621b959..4fc8faf 100644
> --- a/arch/x86/include/asm/tlbflush.h
> +++ b/arch/x86/include/asm/tlbflush.h
> @@ -105,10 +105,10 @@ static inline void flush_tlb_range(struct vm_area_struct *vma,
> __flush_tlb();
> }
>
> -static inline void flush_tlb_mm_range(struct vm_area_struct *vma,
> +static inline void flush_tlb_mm_range(struct mm_struct *mm,
> unsigned long start, unsigned long end, unsigned long vmflag)
> {
> - if (vma->vm_mm == current->active_mm)
> + if (mm == current->active_mm)
> __flush_tlb();
> }
Thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
next prev parent reply other threads:[~2012-07-20 8:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 1:18 [PATCH] x86/tlb: fix allnoconfig building warning Alex Shi
2012-07-20 8:54 ` Borislav Petkov [this message]
2012-07-20 22:34 ` [tip:x86/mm] x86/tlb: Fix build warning and crash when building for !SMP tip-bot for Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120720085436.GC28767@aftab.osrc.amd.com \
--to=bp@amd64.org \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).