From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Kay Sievers <kay@vrfy.org>,
Jason Wessel <jason.wessel@windriver.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
kgdb-bugreport@lists.sourceforge.net
Subject: [PATCH 0/4] KDB: Fix dmesg command
Date: Fri, 20 Jul 2012 17:25:29 -0700 [thread overview]
Message-ID: <20120721002529.GA20567@lizard> (raw)
Hi all,
The dmesg command appears to be broken after the printk rework. The old
logic in the kdb code makes no sense in terms of current printk/logging
storage format, and KDB simply hangs forever upon entering 'dmesg'
command.
The first patch revives the command by switching to kmsg_dumper iterator.
As a side-effect, the code is now much more simpler.
A few changes were needed in the printk.c: we needed unlocked variant
of the kmsg_dumper iterator, but these can surely wait for 3.6.
It's probably too late even for the first patch to go to 3.5, but
I'll try to convince otherwise. :-) Here we go:
- The current code is broken for sure, and has no hope to work at
all. It is a regression;
- The new code works for me, and probably works for everyone else;
- If it compiles (and I urge everyone to compile-test it on your
setup), it hardly can make things worse.
Thanks!
--
include/linux/kmsg_dump.h | 16 +++++++
kernel/debug/kdb/kdb_main.c | 91 +++++++++++++++-------------------------
kernel/debug/kdb/kdb_private.h | 1 -
kernel/printk.c | 83 +++++++++++++++++++++++-------------
4 files changed, 104 insertions(+), 87 deletions(-)
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
next reply other threads:[~2012-07-21 0:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-21 0:25 Anton Vorontsov [this message]
2012-07-21 0:27 ` [PATCH for-3.5 1/4] kdb: Revive dmesg command Anton Vorontsov
2012-07-23 23:19 ` Andrew Morton
2012-07-23 23:38 ` Anton Vorontsov
2012-07-21 0:27 ` [PATCH 2/4] printk: Remove kdb_syslog_data Anton Vorontsov
2012-07-21 0:28 ` [PATCH 3/4] printk: Implement some unlocked kmsg_dump functions Anton Vorontsov
2012-07-21 0:28 ` [PATCH 4/4] kdb: Switch to nolock variants of " Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120721002529.GA20567@lizard \
--to=anton.vorontsov@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason.wessel@windriver.com \
--cc=kay@vrfy.org \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).