From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753712Ab2GUCWI (ORCPT ); Fri, 20 Jul 2012 22:22:08 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:22835 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752219Ab2GUCVL (ORCPT ); Fri, 20 Jul 2012 22:21:11 -0400 X-Authority-Analysis: v=2.0 cv=IOWA+3TG c=1 sm=0 a=s5Htg7xnQOKvHEu9STBOug==:17 a=OpT9cpI26MMA:10 a=Ciwy3NGCPMMA:10 a=IImo4rozYMIA:10 a=5SG0PmZfjMsA:10 a=bbbx4UPp9XUA:10 a=meVymXHHAAAA:8 a=pGLkceISAAAA:8 a=VwQbUJbxAAAA:8 a=ayC55rCoAAAA:8 a=z7YO4etHjzEZLZASiGsA:9 a=QEXdDO2ut3YA:10 a=MSl-tDqOz04A:10 a=jeBq3FmKZ4MA:10 a=zlK5tBA_pVY3p8FievcA:9 a=s5Htg7xnQOKvHEu9STBOug==:117 X-Cloudmark-Score: 0 X-Originating-IP: 72.230.195.127 Message-Id: <20120721022108.261804403@goodmis.org> User-Agent: quilt/0.60-1 Date: Fri, 20 Jul 2012 22:19:50 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Ingo Molnar , Andrew Morton , Masami Hiramatsu , Frederic Weisbecker , Thomas Gleixner , "H. Peter Anvin" , Uros Bizjak Subject: [PATCH 07/19] ftrace/x86_32: Simplify parameter setup for ftrace_regs_caller References: <20120721021943.274162381@goodmis.org> Content-Disposition: inline; filename=0007-ftrace-x86_32-Simplify-parameter-setup-for-ftrace_re.patch Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="00GvhwF7k39YY" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --00GvhwF7k39YY Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable From: Uros Bizjak The final position of the stack after saving regs and setting up the parameters for ftrace_regs_call, is the position of the pt_regs needed for the 4th parameter. Instead of saving it into a temporary reg and pushing the reg, simply push the stack pointer. Link: http://lkml.kernel.org/r/1342702344.12353.16.camel@gandalf.stny.rr.com Signed-off-by: Uros Bizjak Signed-off-by: Steven Rostedt --- arch/x86/kernel/entry_32.S | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S index 46caa56..4dc3017 100644 --- a/arch/x86/kernel/entry_32.S +++ b/arch/x86/kernel/entry_32.S @@ -1169,10 +1169,9 @@ ENTRY(ftrace_regs_caller) movl $__KERNEL_CS,13*4(%esp) =20 movl 12*4(%esp), %eax /* Load ip (1st parameter) */ - movl 0x4(%ebp), %edx /* Load parent ip (2cd parameter) */ - lea (%esp), %ecx - pushl %ecx /* Save pt_regs as 4th parameter */ + movl 0x4(%ebp), %edx /* Load parent ip (2nd parameter) */ leal function_trace_op, %ecx /* Save ftrace_pos in 3rd parameter */ + pushl %esp /* Save pt_regs as 4th parameter */ =20 GLOBAL(ftrace_regs_call) call ftrace_stub --=20 1.7.10.4 --00GvhwF7k39YY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAABAgAGBQJQChIUAAoJEIy3vGnGbaoAYwkP/je7c+cFqIQlupk0hkXsvrMW Ue2tBkbXf8PVeosVTArgF32kM8AAlyUeMOZ7kkHKgGQR7T9YeblUpRB1iz6ZAJB4 mu8+TswM88NoqhtmlL6w60cGiF1SP/SbbJiOfVwEIf+z3BiK+O0B5Tmn1CoDUL6x yD1f2+V6xF9SfbuuSRsH3044kmw1CRd/1oInxpAeC+Bme4GIkf0F7sacalKxuyr0 /MeMZidF77M3OnrwgOI+hpr0lsbmvu4HpZvjqkIc2mOC3q+wfC/nwOE8MAuC43jt T9CaaglV89i0k4RnvM9c8klbWKpAtgiU2sNpfqocvNexDnIXMA69WdTFM85EGk6M ljbAsNcQQ9fEyHaV1pTIvCQ4kLDRXVkPREFRyTMBhENxF9VZN3XssDMel2/I3Own T+YXpSqPS+88UyV6zxW75r6zTn8elVmeiR1Jwnhwrn+W6trhqisAhODo8jQHYqlx C1o6YPDdd08VEu4Es9D2Ne4mDL87CEtp+79r9ejv5GgyXTqe2hUBGRBJwspJTA1K bNlEvf/kZInkGWBUS8VikSy6n5RKJpQQ8KAR29HNTnMCuWHqdHkhTfIoSz9BUMT/ +Z/v1ipDRY7tHOWGHR8hTh8Oc5GUWNrWuUaGPoVWamOVE1P9VM70hJTsc8erR1EY 0yjlEe+IJUrItYP2rtap =KQ8D -----END PGP SIGNATURE----- --00GvhwF7k39YY--