From: Matthew Garrett <mjg@redhat.com>
To: Seiji Aguchi <seiji.aguchi@hds.com>
Cc: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Luck, Tony (tony.luck@intel.com)" <tony.luck@intel.com>,
"mikew@google.com" <mikew@google.com>,
"dzickus@redhat.com" <dzickus@redhat.com>,
"dle-develop@lists.sourceforge.net"
<dle-develop@lists.sourceforge.net>,
Satoru Moriya <satoru.moriya@hds.com>
Subject: Re: [RFC][PATCH v2 0/3] efi_pstore: avoid losing critical message
Date: Mon, 23 Jul 2012 15:13:22 +0100 [thread overview]
Message-ID: <20120723141322.GA23047@srcf.ucam.org> (raw)
In-Reply-To: <A5ED84D3BB3A384992CBB9C77DEDA4D40FB27FAA@USINDEM103.corp.hds.com>
On Thu, Jul 19, 2012 at 09:11:44PM +0000, Seiji Aguchi wrote:
> [Patch Descriptions]
> Patch 1/3 and 2/3 take fist approach, _not_ overwriting entries.
>
> Patch 3/3 takes second approach, adding some logic overwriting entries.
>
> 1/3: Avoid overwriting existing entry
> This patch just avoid overwriting entries to save the 1st critical message
> without being influenced by subsequent events.
I think there's a good argument in favour of this approach. Userspace
crash report tools should be taught to copy the crash data and then
remove the existing entries. It avoids any of the complexity associated
with other approaches and ensures that behaviour is always consistent.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2012-07-23 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 21:11 [RFC][PATCH v2 0/3] efi_pstore: avoid losing critical message Seiji Aguchi
2012-07-21 20:52 ` valdis.kletnieks
2012-07-23 14:13 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120723141322.GA23047@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=dle-develop@lists.sourceforge.net \
--cc=dzickus@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=satoru.moriya@hds.com \
--cc=seiji.aguchi@hds.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).