From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754294Ab2GWSRQ (ORCPT ); Mon, 23 Jul 2012 14:17:16 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:40211 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754085Ab2GWSRP (ORCPT ); Mon, 23 Jul 2012 14:17:15 -0400 Date: Mon, 23 Jul 2012 20:17:08 +0200 From: Arnaldo Carvalho de Melo To: David Ahern Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Jiri Olsa , Namhyung Kim , Frederic Weisbecker , Peter Zijlstra Subject: Re: [PATCH 11/11] perf kvm top: limit guest kernel info message to once Message-ID: <20120723181708.GE6717@infradead.org> References: <1342826756-64663-1-git-send-email-dsahern@gmail.com> <1342826756-64663-12-git-send-email-dsahern@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1342826756-64663-12-git-send-email-dsahern@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Jul 20, 2012 at 05:25:56PM -0600, David Ahern escreveu: > 'perf kvm top' shows a continual flurry of: > Can't find guest [5201]'s kernel information > > if it can't find the guest info and with a lot of VMs running a user > has no chance of reading them all. Limit message to once per guest. > > Signed-off-by: David Ahern > Cc: Arnaldo Carvalho de Melo > Cc: Ingo Molnar > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Frederic Weisbecker > Cc: Peter Zijlstra > --- > tools/perf/builtin-top.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c > index 1706dc9..6285374 100644 > --- a/tools/perf/builtin-top.c > +++ b/tools/perf/builtin-top.c > @@ -706,8 +706,18 @@ static void perf_event__process_sample(struct perf_tool *tool, > int err; > > if (!machine && perf_guest) { > - pr_err("Can't find guest [%d]'s kernel information\n", > - event->ip.pid); > + static struct strlist *seen; > + char pidstr[8]; > + > + if (!seen) > + seen = strlist__new(true, NULL); > + > + scnprintf(pidstr, sizeof(pidstr), "%d", event->ip.pid); > + if (!strlist__has_entry(seen, pidstr)) { > + pr_err("Can't find guest [%d]'s kernel information\n", > + event->ip.pid); > + strlist__add(seen, pidstr); > + } Abuse of strlist? Can't we have an intlist? - Arnaldo