From: Greg KH <gregkh@linuxfoundation.org>
To: Cruz Julian Bishop <cruzjbishop@gmail.com>
Cc: swetland@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] Android: Small documentation changes and a bug fix
Date: Mon, 13 Aug 2012 19:02:42 -0700 [thread overview]
Message-ID: <20120814020242.GC26758@kroah.com> (raw)
In-Reply-To: <1343796860-7025-1-git-send-email-cruzjbishop@gmail.com>
On Wed, Aug 01, 2012 at 02:54:15PM +1000, Cruz Julian Bishop wrote:
> Hi,
>
> This set of patches completes more documentation in android/logger.c, as well as fixing a bug there and a comment formatting issue in android/ashmem.c.
>
> Sorry if kernel-doc was not supposed to be applied to driver files - If it isn't, I'll be sure to remember that for next time. :)
>
> Cruz Julian Bishop (5):
> Fix comment/license formatting in android/ashmem.c
> Complete documentation of logger_entry in android/logger.h
> Finish documentation of two structs in android/logger.c
> Redocument some functions in android/logger.c
> Fixes a potential bug in android/logger.c
In the future, please use a better subject line. Something like:
staging: android: logger: fix finish documentation of structure foo
As it is, I had to go and edit your subjects, and wrap your changelog
comments (72 columns please). In the future, I might not.
thanks,
greg k-h
prev parent reply other threads:[~2012-08-14 2:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 4:54 [PATCH 0/5] Android: Small documentation changes and a bug fix Cruz Julian Bishop
2012-08-01 4:54 ` [PATCH 1/5] Fix comment/license formatting in android/ashmem.c Cruz Julian Bishop
2012-08-01 4:54 ` [PATCH 2/5] Complete documentation of logger_entry in android/logger.h Cruz Julian Bishop
2012-08-01 4:54 ` [PATCH 3/5] Finish documentation of two structs in android/logger.c Cruz Julian Bishop
2012-08-01 4:54 ` [PATCH 4/5] Redocument some functions " Cruz Julian Bishop
2012-08-14 2:00 ` Greg KH
2012-08-01 4:54 ` [PATCH 5/5] Fixes a potential bug " Cruz Julian Bishop
2012-08-01 23:50 ` Ryan Mallon
2012-08-14 2:01 ` Greg KH
2012-08-14 4:08 ` Cruz Julian Bishop
2012-08-01 5:18 ` [PATCH 0/5] Android: Small documentation changes and a bug fix Cruz Julian Bishop
2012-08-14 2:02 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814020242.GC26758@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cruzjbishop@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).